Skip to content

Disable Triton Due to Compatibility Issues #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sayanshaw24 merged 7 commits into from
Feb 4, 2026
Merged

Disable Triton Due to Compatibility Issues #1020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ca9dfe7
add triton and rapidjson patch
Feb 3, 2026
e2f6e3e
add support for AlmaLinux and Rocky Linux
Feb 3, 2026
65fd7f9
fix GCC 14 compatibility issues
Feb 3, 2026
0f18867
use RapidJSON master with GCC 14 fixes and backward compat patch
Feb 3, 2026
09c0ee9
use RapidJSON master with GCC 14 fixes and backward compat patch
Feb 3, 2026
57dab62
remove patch
Feb 3, 2026
d2d6de2
disable triton
Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,10 @@ set(OCOS_ONNXRUNTIME_PKG_URI "" CACHE STRING
set(OCOS_BUILD_PRESET "" CACHE STRING
"Specify the build preset cmake settings file path, like 'token_api_only' which includes ./cmake/presets/token_api_only.cmake")

# AzureOp can be enabled by environment varaible OCOS_ENABLE_AZURE == 1
if (DEFINED ENV{OCOS_ENABLE_AZURE})
# AzureOp can be enabled by environment variable OCOS_ENABLE_AZURE=1
if (DEFINED ENV{OCOS_ENABLE_AZURE} AND "$ENV{OCOS_ENABLE_AZURE}" STREQUAL "1")
set(OCOS_ENABLE_AZURE ON CACHE INTERNAL "" FORCE)
message(STATUS "=> AzureOp is enabled env variable.")
message(STATUS "=> AzureOp is enabled via environment variable.")
endif()

function(disable_all_operators)
Expand Down
2 changes: 1 addition & 1 deletion cmake/externals/triton.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,4 +145,4 @@ ExternalProject_Add(triton
add_dependencies(triton ${triton_dependencies})

ExternalProject_Get_Property(triton SOURCE_DIR BINARY_DIR)
set(triton_THIRD_PARTY_DIR ${BINARY_DIR}/third-party)
set(triton_THIRD_PARTY_DIR ${BINARY_DIR}/third-party)
5 changes: 3 additions & 2 deletions cmake/externals/triton_cmake.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@ diff --git a/CMakeLists.txt b/CMakeLists.txt
index 7b11178..7749fa9 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -115,10 +115,11 @@ if(TRITON_ENABLE_CC_HTTP OR TRITON_ENABLE_CC_GRPC OR TRITON_ENABLE_PERF_ANALYZER
@@ -115,10 +115,12 @@ if(TRITON_ENABLE_CC_HTTP OR TRITON_ENABLE_CC_GRPC OR TRITON_ENABLE_PERF_ANALYZER
file(STRINGS /etc/os-release DISTRO REGEX "^NAME=")
string(REGEX REPLACE "NAME=\"(.*)\"" "\\1" DISTRO "${DISTRO}")
message(STATUS "Distro Name: ${DISTRO}")
- if(DISTRO STREQUAL "CentOS Linux")
+ if(DISTRO STREQUAL "CentOS Linux" AND CMAKE_SIZEOF_VOID_P EQUAL 8)
+ # Check for CentOS, AlmaLinux, or Rocky Linux (used by newer manylinux images) on 64-bit systems
+ if((DISTRO STREQUAL "CentOS Linux" OR DISTRO STREQUAL "AlmaLinux" OR DISTRO STREQUAL "Rocky Linux") AND CMAKE_SIZEOF_VOID_P EQUAL 8)
set (CURL_LIB_DIR "lib64")
endif()
endif()
Expand Down
Loading