Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Top K CPU #1194

Merged
merged 16 commits into from
Jan 21, 2025
Merged

Fix Top K CPU #1194

merged 16 commits into from
Jan 21, 2025

Conversation

aciddelgado
Copy link
Contributor

Fixes this issue #1184 where top K didn't work for CPU.

natke
natke previously requested changes Jan 16, 2025
Copy link
Contributor

@natke natke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests that would have elicited this issue

src/search.cpp Outdated Show resolved Hide resolved
src/search.cpp Outdated Show resolved Hide resolved
src/search.cpp Outdated Show resolved Hide resolved
baijumeswani
baijumeswani previously approved these changes Jan 17, 2025
src/search.cpp Outdated Show resolved Hide resolved
src/search.cpp Outdated Show resolved Hide resolved
@baijumeswani baijumeswani dismissed their stale review January 17, 2025 07:42

Accidental approval! sorry

Copy link
Contributor

@natke natke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding tests!

@natke natke dismissed their stale review January 17, 2025 21:01

Tests were added

test/sampling_tests.cpp Outdated Show resolved Hide resolved
test/sampling_tests.cpp Outdated Show resolved Hide resolved
test/sampling_tests.cpp Outdated Show resolved Hide resolved
test/sampling_tests.cpp Outdated Show resolved Hide resolved
test/sampling_tests.cpp Outdated Show resolved Hide resolved
test/sampling_tests.cpp Outdated Show resolved Hide resolved
test/sampling_tests.cpp Outdated Show resolved Hide resolved
test/sampling_tests.cpp Outdated Show resolved Hide resolved
test/sampling_tests.cpp Outdated Show resolved Hide resolved
@aciddelgado aciddelgado merged commit 8338d07 into main Jan 21, 2025
10 of 14 checks passed
@aciddelgado aciddelgado deleted the aciddelgado/fix_top_k branch January 21, 2025 21:54
@natke natke added the 0.6.0 label Jan 21, 2025
baijumeswani pushed a commit that referenced this pull request Jan 30, 2025
Fixes this issue #1184 where top K didn't work for CPU.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants