-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCm] add -Wno-pass-failed for CK build #20859
base: main
Are you sure you want to change the base?
Conversation
Newer hip-clang compilers will generate warnings. See ROCm/composable_kernel#1105.
If we upgrade our CK version, will this error be gone? |
No, I don't think so. The problem shows up for MI100 (gfx908) and a yet-to-release version of the hip-clang compiler surfacing a warning that hadn't been before. The CK PR above adds the -Wno-pass-failed flag to its own build, but onnxruntime doesn't pick up that flag when it includes CK. If you have a better idea of how to add this flag to the ROCm[CK] build, I'm open to suggestions. |
But the targets like device_gemm_instance are from CK? They are not onnxruntime libraries. |
Correct, those targets are coming from the |
Could someone who familiar with AMD EPs help take a look? |
I don't know it much. I feel this change is not needed.
ping @tianleiwu realized this may be stale. Likely this should still go in |
/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline |
/azp run Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Linux Android Emulator QNN CI Pipeline |
/azp run Android CI Pipeline,iOS CI Pipeline,ONNX Runtime React Native CI Pipeline,CoreML CI Pipeline,Linux DNNL CI Pipeline,Linux MIGraphX CI Pipeline,Linux ROCm CI Pipeline |
Azure Pipelines successfully started running 7 pipeline(s). |
Azure Pipelines successfully started running 8 pipeline(s). |
Azure Pipelines successfully started running 10 pipeline(s). |
/azp run orttraining-linux-ci-pipeline |
No pipelines are associated with this pull request. |
We do not apply -Werror to external libraries(device_gemm_instance), then why do we need to suppress this warning? |
Newer hip-clang compilers will generate warnings.
See ROCm/composable_kernel#1105.