Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm] add -Wno-pass-failed for CK build #20859

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeffdaily
Copy link
Contributor

Newer hip-clang compilers will generate warnings.
See ROCm/composable_kernel#1105.

Newer hip-clang compilers will generate warnings.
See ROCm/composable_kernel#1105.
snnn
snnn previously approved these changes May 30, 2024
@snnn
Copy link
Member

snnn commented May 30, 2024

If we upgrade our CK version, will this error be gone?

@jeffdaily
Copy link
Contributor Author

No, I don't think so. The problem shows up for MI100 (gfx908) and a yet-to-release version of the hip-clang compiler surfacing a warning that hadn't been before. The CK PR above adds the -Wno-pass-failed flag to its own build, but onnxruntime doesn't pick up that flag when it includes CK. If you have a better idea of how to add this flag to the ROCm[CK] build, I'm open to suggestions.

@snnn
Copy link
Member

snnn commented May 30, 2024

But the targets like device_gemm_instance are from CK? They are not onnxruntime libraries.

@jeffdaily
Copy link
Contributor Author

But the targets like device_gemm_instance are from CK? They are not onnxruntime libraries.

Correct, those targets are coming from the include(composable_kernel) in cmake/onnxruntime_providers_rocm.cmake. They are linked to the ROCm EP library.

@snnn
Copy link
Member

snnn commented Jun 19, 2024

Could someone who familiar with AMD EPs help take a look?

@snnn snnn added ep:MIGraphX issues related to AMD MI GraphX execution provider ep:ROCm questions/issues related to ROCm execution provider labels Jun 19, 2024
@snnn snnn dismissed their stale review June 19, 2024 00:56

I don't know it much. I feel this change is not needed.

@TedThemistokleous
Copy link
Contributor

ping @tianleiwu realized this may be stale. Likely this should still go in

@tianleiwu
Copy link
Contributor

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline

@tianleiwu
Copy link
Contributor

/azp run Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Linux Android Emulator QNN CI Pipeline

@tianleiwu
Copy link
Contributor

/azp run Android CI Pipeline,iOS CI Pipeline,ONNX Runtime React Native CI Pipeline,CoreML CI Pipeline,Linux DNNL CI Pipeline,Linux MIGraphX CI Pipeline,Linux ROCm CI Pipeline

Copy link

Azure Pipelines successfully started running 7 pipeline(s).

Copy link

Azure Pipelines successfully started running 8 pipeline(s).

Copy link

Azure Pipelines successfully started running 10 pipeline(s).

@tianleiwu
Copy link
Contributor

/azp run orttraining-linux-ci-pipeline

Copy link

No pipelines are associated with this pull request.

@snnn
Copy link
Member

snnn commented Dec 26, 2024

We do not apply -Werror to external libraries(device_gemm_instance), then why do we need to suppress this warning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ep:MIGraphX issues related to AMD MI GraphX execution provider ep:ROCm questions/issues related to ROCm execution provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants