Skip to content

Add trace event control for ORT Web performance profiling #23393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 9, 2025

Conversation

qwu16
Copy link
Contributor

@qwu16 qwu16 commented Jan 16, 2025

Description

Add trace event control to better profile ORT web performance

Motivation and Context

ORT Web's current tracing implementation lacks interfaces for performance profiling using about://tracing. This PR introduces these interfaces, enabling performance bottleneck identification in ORT Web and adding several trace events for WebNN.

@qwu16
Copy link
Contributor Author

qwu16 commented Jan 16, 2025

@microsoft-github-policy-service agree company="Intel"

@qwu16
Copy link
Contributor Author

qwu16 commented Jan 16, 2025

@Honry Please help review this PR, thanks~

Copy link
Contributor

@Honry Honry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fs-eire, please help review the type script files. Thanks!

@guschmue guschmue added the ep:WebNN WebNN execution provider label Jan 16, 2025
@qwu16
Copy link
Contributor Author

qwu16 commented Apr 17, 2025

@fs-eire @guschmue Please help review this PR, thanks~

@fs-eire
Copy link
Contributor

fs-eire commented Apr 17, 2025

The CI is failing and need to fix the linter error

@qwu16
Copy link
Contributor Author

qwu16 commented Apr 18, 2025

The CI is failing and need to fix the linter error

Thanks for the review, js format issue has been fixed, please help review again.

@qwu16
Copy link
Contributor Author

qwu16 commented Apr 26, 2025

@fs-eire It seems the Lint check failed in CI, and there is no specific error hint in the log. I have run "npm run format; npm run lint; lintrunner -a" commands in local to check the javascript and C++ code, and there is no error in my local check. Are there any other format rule we need to follow? Is there any guide for this?

@qwu16
Copy link
Contributor Author

qwu16 commented May 8, 2025

@fs-eire Rebase the branch and update the lint format check, please help review, thanks~

@fs-eire
Copy link
Contributor

fs-eire commented May 9, 2025

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,ONNX Runtime Web CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline

@fs-eire
Copy link
Contributor

fs-eire commented May 9, 2025

/azp run Linux QNN CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Linux Android Emulator QNN CI Pipeline,Android CI Pipeline,iOS CI Pipeline,ONNX Runtime React Native CI Pipeline,Linux DNNL CI Pipeline,Linux MIGraphX CI Pipeline,Linux ROCm CI Pipeline

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@qwu16
Copy link
Contributor Author

qwu16 commented May 9, 2025

@fs-eire I checked the failed CI cases, it seems not relate to this PR, do we need to retrigger the CI?

@fs-eire fs-eire merged commit 8a97463 into microsoft:main May 9, 2025
83 of 92 checks passed
@fs-eire
Copy link
Contributor

fs-eire commented May 9, 2025

@fs-eire I checked the failed CI cases, it seems not relate to this PR, do we need to retrigger the CI?

I checked the failed jobs. The failures are not related so it’s safe to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ep:WebNN WebNN execution provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants