Fix WebGPU ConvTranspose bias validation in TypeScript and C++ implementations by Copilot · Pull Request #27213 · microsoft/onnxruntime

Copilot · 2026-01-30T16:21:31Z

Description

WebGPU EP's ConvTranspose operator failed to properly validate bias tensor shape in both TypeScript and C++ implementations. Undefined group attribute caused NaN in validation checks, allowing invalid bias tensors to pass.

TypeScript Changes (js/web/lib/wasm/jsep/webgpu/ops/conv-transpose.ts):

Parse time default: Set group to 1 when undefined (line 135 in parseConvTransposeAttributes)
Merged bias validation (lines 181-186 in validateInputs):
- Validates bias is 1D and size matches output channels in single condition
- Uses simple 'invalid bias' error message matching Conv operator pattern

C++ Changes (onnxruntime/core/providers/webgpu/nn/conv_transpose.cc):

Merged bias validation (lines 61-64 in ComputeInternal):
- Validates bias is 1D and size matches output channels in single condition
- Uses simple "invalid bias" error message matching Conv operator pattern

Code Formatting:

Applied prettier formatting to ensure TypeScript code adheres to project style guidelines
Applied lintrunner formatting fixes to remove trailing whitespace in C++ code

Motivation and Context

Addresses issue where tests with intentionally invalid bias shapes were incorrectly passing in the WebGPU EP. The fix ensures:

Invalid bias shapes are properly rejected in both TypeScript and C++ implementations
NaN bugs prevented across all code paths using group attribute in TypeScript
Validation conditions are merged into single checks with OR operators for cleaner code
Error messages use simple 'invalid bias' format matching Conv operator pattern
Consistent validation logic across both WebGPU backend implementations
Enables compatibility with tests in PR [CPU/CUDA] Add bias input validations for ConvTranspose #27209 for WebGPU EP
Code passes all linting and formatting checks (prettier and lintrunner)

Note: The C++ implementation already handles group attribute defaulting to 1 in the ConvAttributes base class, so only bias validation needed to be added.

Original prompt

This section details on the original issue you should resolve

<issue_title>[Web] WebGPU EP's ConvTranspose input validation seems loose</issue_title>
<issue_description>### Describe the issue

As title.

The WebGPU EP's ConvTranspose operator neglects to check if the bias is of the expected shape. See tests added in #27209. The WebGPU EP "passes" those tests when a failure of some sort is expected (preferably along the lines of bias is not of the expected shape). Not sure if this is masking a bug of some sort.

To reproduce

Run tests in #27209 with the WebGPU EP

Urgency

Not urgent

ONNX Runtime Installation

Built from Source

ONNX Runtime Version or Commit ID

Run tests in PR branch #27209

Execution Provider

'webgpu' (WebGPU)</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes [Web] WebGPU EP's ConvTranspose input validation seems loose #27210

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: guschmue <22941064+guschmue@users.noreply.github.com>

…ndant check Co-authored-by: guschmue <22941064+guschmue@users.noreply.github.com>

Co-authored-by: guschmue <22941064+guschmue@users.noreply.github.com>

guschmue

you also need to make the change in onnxruntime/core/providers/webgpu/nn/conv_transpose.cc

Co-authored-by: guschmue <22941064+guschmue@users.noreply.github.com>

Copilot · 2026-01-30T16:44:21Z

you also need to make the change in onnxruntime/core/providers/webgpu/nn/conv_transpose.cc

Added bias validation to the C++ implementation in commit 0d53e11. The validation checks that bias is 1D and has size equal to output channels (group * filter_shape[1]), matching the logic in the TypeScript implementation.

github-actions

You can commit the suggested changes from lintrunner.

onnxruntime/core/providers/webgpu/nn/conv_transpose.cc

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

guschmue

lint is failing:
Error: Following source files are not formatted: (did you run "npm run format"?)
js/web/lib/wasm/jsep/webgpu/ops/conv-transpose.ts

Co-authored-by: guschmue <22941064+guschmue@users.noreply.github.com>

Copilot · 2026-01-30T16:55:27Z

lint is failing:
Error: Following source files are not formatted: (did you run "npm run format"?)
js/web/lib/wasm/jsep/webgpu/ops/conv-transpose.ts

Fixed formatting by running prettier in commit 7c55b81. The file now passes linting checks.

guschmue · 2026-01-30T17:35:07Z

/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline

azure-pipelines · 2026-01-30T17:35:27Z

Azure Pipelines successfully started running 4 pipeline(s).

js/web/lib/wasm/jsep/webgpu/ops/conv-transpose.ts

onnxruntime/core/providers/webgpu/nn/conv_transpose.cc

hariharans29

Can the error check conditions be merged and the error message align with the error message in #27209 so that it is easier to enable the test in #27209 for the WebGPU EP ?

guschmue

resolve pending review feedback

Co-authored-by: guschmue <22941064+guschmue@users.noreply.github.com>

Copilot · 2026-02-05T17:18:10Z

Can the error check conditions be merged and the error message align with the error message in #27209 so that it is easier to enable the test in https://gi...

Merged the validation conditions and simplified error messages in both TypeScript and C++ implementations in commit 4c850b7. The error message now matches the Conv operator pattern with 'invalid bias', which should enable the tests in PR #27209 for WebGPU EP.

github-actions

You can commit the suggested changes from lintrunner.

onnxruntime/core/providers/webgpu/nn/conv_transpose.cc

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

guschmue

run
lintrunner -a
to fix formatting

Co-authored-by: guschmue <22941064+guschmue@users.noreply.github.com>

Copilot · 2026-02-05T20:00:18Z

run
lintrunner -a
to fix formatting

Ran lintrunner -a and applied the formatting fixes in commit 9c9ef07.

guschmue · 2026-02-05T20:04:20Z

/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline

azure-pipelines · 2026-02-05T20:04:43Z

Azure Pipelines successfully started running 4 pipeline(s).

…entations (#27213) ### Description WebGPU EP's ConvTranspose operator failed to properly validate bias tensor shape in both TypeScript and C++ implementations. Undefined `group` attribute caused NaN in validation checks, allowing invalid bias tensors to pass. **TypeScript Changes** (`js/web/lib/wasm/jsep/webgpu/ops/conv-transpose.ts`): - **Parse time default**: Set `group` to 1 when undefined (line 135 in `parseConvTransposeAttributes`) ```typescript const group = (attributes.group as number) ?? 1; // per ONNX spec ``` - **Enhanced bias validation** (lines 182-192 in `validateInputs`): - Check bias is 1D before accessing dimensions - Validate bias size matches output channels: `weight.dims[1] * group` - Descriptive errors showing actual vs expected values ```typescript if (inputs.length === 3) { if (inputs[2].dims.length !== 1) { throw new Error('invalid bias: bias must be 1D tensor'); } const featureMaps = inputs[1].dims[1] * attributes.group; if (inputs[2].dims[0] !== featureMaps) { throw new Error( `invalid bias: bias size (${inputs[2].dims[0]}) must be equal to output channels (${featureMaps})`, ); } } ``` **C++ Changes** (`onnxruntime/core/providers/webgpu/nn/conv_transpose.cc`): - **Added bias validation** (lines 61-71 in `ComputeInternal`): - Validates bias is 1D tensor - Validates bias size matches output channels (`num_output_channels = group * filter_shape[1]`) - Uses consistent error messages with TypeScript implementation ```cpp // Validate bias shape if provided if (has_bias) { const auto& bias_shape = bias->Shape(); if (bias_shape.NumDimensions() != 1) { return ORT_MAKE_STATUS(ONNXRUNTIME, INVALID_ARGUMENT, "invalid bias: bias must be 1D tensor"); } if (bias_shape[0] != num_output_channels) { return ORT_MAKE_STATUS(ONNXRUNTIME, INVALID_ARGUMENT, "invalid bias: bias size (", bias_shape[0], ") must be equal to output channels (", num_output_channels, ")"); } } ``` **Code Formatting**: - Applied prettier formatting to ensure TypeScript code adheres to project style guidelines (120 character line width, proper line breaks for long error messages) ### Motivation and Context Addresses issue where tests with intentionally invalid bias shapes were incorrectly passing in the WebGPU EP. The fix ensures: - Invalid bias shapes are properly rejected in both TypeScript and C++ implementations - NaN bugs prevented across all code paths using `group` attribute in TypeScript - Clear error messages for debugging - Consistent validation logic across both WebGPU backend implementations - Code passes all linting and formatting checks Note: The C++ implementation already handles `group` attribute defaulting to 1 in the ConvAttributes base class, so only bias validation needed to be added.  <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>[Web] WebGPU EP's ConvTranspose input validation seems loose</issue_title> > <issue_description>### Describe the issue > > As title. > > The WebGPU EP's ConvTranspose operator neglects to check if the bias is of the expected shape. See tests added in #27209. The WebGPU EP "passes" those tests when a failure of some sort is expected (preferably along the lines of bias is not of the expected shape). Not sure if this is masking a bug of some sort. > > ### To reproduce > > Run tests in #27209 with the WebGPU EP > > ### Urgency > > Not urgent > > ### ONNX Runtime Installation > > Built from Source > > ### ONNX Runtime Version or Commit ID > > Run tests in PR branch #27209 > > ### Execution Provider > > 'webgpu' (WebGPU)</issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details>  - Fixes #27210  --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: guschmue <22941064+guschmue@users.noreply.github.com> Co-authored-by: Guenther Schmuelling <guschmue@microsoft.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

This cherry-picks the following commits for the 1.24.2 release: - #27096 - #27077 - #26677 - #27238 - #27213 - #27256 - #27278 - #27275 - #27276 - #27216 - #27271 - #27299 - #27294 - #27266 - #27176 - #27126 - #27252 --------- Co-authored-by: Xiaofei Han <xiaofeihan@microsoft.com> Co-authored-by: Jiajia Qin <jiajiaqin@microsoft.com> Co-authored-by: Yulong Wang <7679871+fs-eire@users.noreply.github.com> Co-authored-by: qti-monumeen <monumeen@qti.qualcomm.com> Co-authored-by: Ankit Maheshkar <ankit.maheshkar@intel.com> Co-authored-by: Eric Crawford <eric.r.crawford@intel.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: guschmue <22941064+guschmue@users.noreply.github.com> Co-authored-by: Guenther Schmuelling <guschmue@microsoft.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: angelser <32746004+angelser@users.noreply.github.com> Co-authored-by: Angela Serrano Brummett <angelser@microsoft.com> Co-authored-by: Misha Chornyi <99709299+mc-nv@users.noreply.github.com> Co-authored-by: hariharans29 <9969784+hariharans29@users.noreply.github.com> Co-authored-by: eserscor <erscor@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Baiju Meswani <bmeswani@microsoft.com> Co-authored-by: Adrian Lizarraga <adlizarraga@microsoft.com> Co-authored-by: Ti-Tai Wang <titaiwang@microsoft.com> Co-authored-by: bmehta001 <bmehta001@users.noreply.github.com>

Initial plan

1488dc3

Copilot AI assigned Copilot and guschmue Jan 30, 2026

Copilot started work on behalf of guschmue January 30, 2026 16:21 View session

Copilot AI and others added 3 commits January 30, 2026 16:28

Enhance ConvTranspose bias validation with better error messages

d3658b0

Co-authored-by: guschmue <22941064+guschmue@users.noreply.github.com>

Address code review feedback - use nullish coalescing and remove redu…

a7b6b3a

…ndant check Co-authored-by: guschmue <22941064+guschmue@users.noreply.github.com>

Fix group attribute default at parse time instead of validation time

583f08b

Co-authored-by: guschmue <22941064+guschmue@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix input validation for ConvTranspose bias in WebGPU EP~~ Fix WebGPU ConvTranspose bias validation Jan 30, 2026

Copilot finished work on behalf of guschmue January 30, 2026 16:37

Copilot AI requested a review from guschmue January 30, 2026 16:37

guschmue requested changes Jan 30, 2026

View reviewed changes

Copilot started work on behalf of guschmue January 30, 2026 16:41 View session

Add bias validation to C++ WebGPU ConvTranspose implementation

0d53e11

Co-authored-by: guschmue <22941064+guschmue@users.noreply.github.com>

Copilot AI changed the title ~~Fix WebGPU ConvTranspose bias validation~~ Fix WebGPU ConvTranspose bias validation in TypeScript and C++ implementations Jan 30, 2026

Copilot AI requested a review from guschmue January 30, 2026 16:46

Copilot finished work on behalf of guschmue January 30, 2026 16:46

github-actions bot reviewed Jan 30, 2026

View reviewed changes

onnxruntime/core/providers/webgpu/nn/conv_transpose.cc Outdated Show resolved Hide resolved

onnxruntime/core/providers/webgpu/nn/conv_transpose.cc Outdated Show resolved Hide resolved

onnxruntime/core/providers/webgpu/nn/conv_transpose.cc Outdated Show resolved Hide resolved

guschmue and others added 3 commits January 30, 2026 08:51

Apply suggestion from @github-actions[bot]

d8dc88a

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Apply suggestion from @github-actions[bot]

7c969c5

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Apply suggestion from @github-actions[bot]

cf72464

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

guschmue requested changes Jan 30, 2026

View reviewed changes

Copilot started work on behalf of guschmue January 30, 2026 16:53 View session

Run prettier to fix formatting in conv-transpose.ts

7c55b81

Co-authored-by: guschmue <22941064+guschmue@users.noreply.github.com>

Copilot AI requested a review from guschmue January 30, 2026 16:56

Copilot finished work on behalf of guschmue January 30, 2026 16:56

guschmue approved these changes Jan 30, 2026

View reviewed changes

hariharans29 reviewed Jan 31, 2026

View reviewed changes

js/web/lib/wasm/jsep/webgpu/ops/conv-transpose.ts Outdated Show resolved Hide resolved

hariharans29 reviewed Jan 31, 2026

View reviewed changes

onnxruntime/core/providers/webgpu/nn/conv_transpose.cc Outdated Show resolved Hide resolved

hariharans29 requested changes Jan 31, 2026

View reviewed changes

guschmue requested changes Feb 5, 2026

View reviewed changes

Copilot started work on behalf of guschmue February 5, 2026 17:15 View session

Merge bias validation conditions and simplify error message

4c850b7

Co-authored-by: guschmue <22941064+guschmue@users.noreply.github.com>

Copilot AI dismissed fs-eire’s stale review via 4c850b7 February 5, 2026 17:17

Copilot finished work on behalf of guschmue February 5, 2026 17:19

Copilot AI requested a review from guschmue February 5, 2026 17:19

guschmue approved these changes Feb 5, 2026

View reviewed changes

github-actions bot reviewed Feb 5, 2026

View reviewed changes

onnxruntime/core/providers/webgpu/nn/conv_transpose.cc Outdated Show resolved Hide resolved

Apply suggestion from @github-actions[bot]

fcdab4f

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

guschmue requested changes Feb 5, 2026

View reviewed changes

Copilot started work on behalf of guschmue February 5, 2026 19:57 View session

Fix formatting with lintrunner

9c9ef07

Co-authored-by: guschmue <22941064+guschmue@users.noreply.github.com>

Copilot AI requested a review from guschmue February 5, 2026 20:01

Copilot finished work on behalf of guschmue February 5, 2026 20:01

guschmue approved these changes Feb 5, 2026

View reviewed changes

hariharans29 approved these changes Feb 5, 2026

View reviewed changes

guschmue merged commit b75bfe1 into main Feb 6, 2026
88 checks passed

guschmue deleted the copilot/fix-convtranspose-input-validation branch February 6, 2026 01:27

tianleiwu added the release:1.24.2 label Feb 10, 2026

tianleiwu mentioned this pull request Feb 12, 2026

ORT 1.24.2 release cherry pick round 1 #27330

Merged

tianleiwu removed the release:1.24.2 label Feb 12, 2026

Conversation

Copilot AI commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

To reproduce

Urgency

ONNX Runtime Installation

ONNX Runtime Version or Commit ID

Execution Provider

Comments on the Issue (you are @copilot in this section)

Uh oh!

guschmue left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jan 30, 2026

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guschmue left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jan 30, 2026

Uh oh!

guschmue commented Jan 30, 2026

Uh oh!

azure-pipelines bot commented Jan 30, 2026

Uh oh!

Uh oh!

Uh oh!

hariharans29 left a comment

Choose a reason for hiding this comment

Uh oh!

guschmue left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Feb 5, 2026

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

guschmue left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Feb 5, 2026

Uh oh!

guschmue commented Feb 5, 2026

Uh oh!

azure-pipelines bot commented Feb 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Jan 30, 2026 •

edited

Loading