Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes two issues in the DML NuGet packaging pipeline: (1) packaging build failures caused by multiple .nupkg files (main package and symbols package) when using the Windows ren command, and (2) Component Governance warnings due to Python 3.12's removal of the distutils module.
Changes:
- Added setuptools installation to resolve Python 3.12 distutils deprecation
- Replaced fragile batch
rencommand with explicit PowerShell logic to rename only the main .nupkg file (not symbols package) - Fixed trailing whitespace
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c7f121c to
f8fd180
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix DML NuGet Packaging Build Failure & Component Governance Warnings
I have addressed three distinct issues, incorporating feedback to improve robustness.
Changes
1. Fix arm64 Job Renaming
Replaced
renwith PowerShell + error handling:File: tools/ci_build/github/azure-pipelines/dml-nuget-packaging.yml
2. Fix Bundling Script (Multiple Matches)
The script was finding multiple packages (Release vs Dev, Main vs Symbols) and failing. I updated it to robustness selection logic:
*.symbols.nupkg.1.24.1.nupkgvs1.24.1-dev...nupkg), select the one with the shortest filename, which prioritizes the canonical Release package.File: tools/ci_build/github/windows/bundle_dml_package.ps1
3. Fix Component Governance Warnings
Added
setuptoolsinstallation for Python 3.12 compatibility.