Skip to content

Fix out-of-bounds read vulnerability in ArrayFeatureExtractor #27275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hariharans29 merged 3 commits into from
Feb 9, 2026
+10 −2
Merged

Fix out-of-bounds read vulnerability in ArrayFeatureExtractor #27275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d8107b
Initial plan
Copilot Feb 6, 2026
9d8fc43
Add bounds check for negative indices in ArrayFeatureExtractor
Copilot Feb 6, 2026
9b6915f
Fix out-of-bounds read vulnerability in ArrayFeatureExtractor
Copilot Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions onnxruntime/core/providers/cpu/ml/array_feature_extractor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,10 @@ common::Status ArrayFeatureExtractorOp<T>::Compute(OpKernelContext* context) con
}

for (int64_t i = 0; i < num_indices; ++i) {
if (y_data[i] >= stride) {
if (y_data[i] < 0 || y_data[i] >= stride) {
return ORT_MAKE_STATUS(
ONNXRUNTIME, INVALID_ARGUMENT,
"Invalid Y argument: index is out of range: Y[", i, "] (", y_data[i], ") >=", stride);
"Invalid Y argument: index is out of range: Y[", i, "] (", y_data[i], ") must be in [0, ", stride, ")");
}
}

Expand Down
8 changes: 8 additions & 0 deletions onnxruntime/test/providers/cpu/ml/array_feature_extractor_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,5 +109,13 @@ TEST_F(ArrayFeatureExtractorTest, InvalidInputOutOfBoundsY) {
test_.Run(OpTester::ExpectResult::kExpectFailure);
}

TEST_F(ArrayFeatureExtractorTest, InvalidInputNegativeY) {
test_.AddInput<int64_t>("X", {10, 1}, {0, 1, 2, 3, 4, 5, 6, 7, 8, 9});
test_.AddInput<int64_t>("Y", {1}, {-10});
// Should fail due to negative index -10
test_.AddOutput<int64_t>("Z", {0}, {});
test_.Run(OpTester::ExpectResult::kExpectFailure);
}

} // namespace test
} // namespace onnxruntime
Loading