Skip to content

[NvTensorRTRTX EP]: Add missing override specifiers to suppress warnings #27288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theHamsta wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[NvTensorRTRTX EP]: Add missing override specifiers to suppress warnings #27288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions onnxruntime/core/providers/nv_tensorrt_rtx/nv_execution_provider.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,8 @@ class NvExecutionProvider : public IExecutionProvider {
const GraphOptimizerRegistry& graph_optimizer_registry,
IResourceAccountant* /* resource_accountant */) const override;

int GetDeviceId() const { return device_id_; }
Status Sync() const;
int GetDeviceId() const override { return device_id_; }
Status Sync() const override;

common::Status Compile(const std::vector<FusedNodeAndGraph>& fused_nodes_and_graphs,
std::vector<NodeComputeInfo>& node_compute_funcs) override;
Expand Down
4 changes: 2 additions & 2 deletions onnxruntime/core/providers/nv_tensorrt_rtx/nv_provider_factory.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ struct NvProviderFactory : IExecutionProviderFactory {

std::unique_ptr<IExecutionProvider> CreateProvider() override;
std::unique_ptr<IExecutionProvider> CreateProvider(const OrtSessionOptions& session_options,
const OrtLogger& session_logger);
const OrtLogger& session_logger) override;

private:
NvExecutionProviderInfo info_;
Expand Down Expand Up @@ -110,7 +110,7 @@ struct Nv_Provider : Provider {
return std::make_shared<NvProviderFactory>(info);
}

std::shared_ptr<IExecutionProviderFactory> CreateExecutionProviderFactory(const void* param) {
std::shared_ptr<IExecutionProviderFactory> CreateExecutionProviderFactory(const void* param) override {
if (param == nullptr) {
LOGS_DEFAULT(ERROR) << "[NvTensorRTRTX EP] Passed NULL options to CreateExecutionProviderFactory()";
return nullptr;
Expand Down
Loading