Fix ARM64 cross-compilation target platform detection#27309
Open
ingyukoh wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix ARM64 cross-compilation target platform detection#27309ingyukoh wants to merge 1 commit intomicrosoft:mainfrom
ingyukoh wants to merge 1 commit intomicrosoft:mainfrom
Conversation
When cross-compiling, CMAKE_SYSTEM_PROCESSOR may incorrectly reflect the build host instead of the target. Use the compiler's -dumpmachine output to detect the actual target architecture. Fixes microsoft#25201
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cross-compiling from x86 to ARM64,
CMAKE_SYSTEM_PROCESSORmay incorrectly reflect thebuild host instead of the target architecture. This causes cpuinfo linking errors:
cpuinfo_initialize (and friends) are not found when linking
Description
When
CMAKE_CROSSCOMPILINGis true, detect the target architecture from the cross-compiler's-dumpmachineoutput instead of relying onCMAKE_SYSTEM_PROCESSOR.Motivation and Context
Fixes #25201
Users cross-compiling with
aarch64-linux-gnu-gccwould get the wrongonnxruntime_target_platformbecause the code used the build host's architecture instead ofthe compiler's target.