Fix XNNPACK Clip/Relu fusion when the producer output has other consumers#28814
Open
tairenpiao wants to merge 1 commit into
Open
Fix XNNPACK Clip/Relu fusion when the producer output has other consumers#28814tairenpiao wants to merge 1 commit into
tairenpiao wants to merge 1 commit into
Conversation
…mers (microsoft#28543) Reject the fusion if the Conv/MaxPool/AveragePool output is a graph output or has a non-activation consumer; the fused node only exposes the activation output. Add a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ClipReluCheckerfuses Conv/MaxPool/AveragePool with a following Clip/Relu without checking other consumers of the producer output. The fused node only exposes the activation output, so a side consumer (or graph output) of the pre-activation value is left dangling and session creation fails withInvalid model. Node input '...' is not a graph input, initializer, or output of a previous node. Reject the fusion in that case.Adds
XnnpackEP.TestPoolReluFusionRejectedWithSideConsumer.Motivation and Context
Fixes #28543, fixes #28544.