Fix attention mask to use float_lowest instead of -inf and add NaN-safe softmax handling#2654
Conversation
…est for softmax NaN case
|
@microsoft-github-policy-service agree |
|
If this PR is facilitated by an AI, please disclose its usage. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2654 +/- ##
=======================================
Coverage 70.45% 70.45%
=======================================
Files 228 228
Lines 27177 27177
Branches 2734 2734
=======================================
Hits 19148 19148
Misses 7092 7092
Partials 937 937 ☔ View full report in Codecov by Sentry. |
|
I went through the questions you mentioned and yes, i used AI assistance to help add the unit test. |
justinchuby
left a comment
There was a problem hiding this comment.
I think this is reasonable. @xadupre @titaiwangms what do you think?
|
Yeah, that's also what ort folk would suggest: microsoft/onnxruntime#27129 (comment) |
|
@Aniketsy could you fix the lint issues? Thanks |
|
@justinchuby fixed lint error. |
#2561
Please let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.
Thankyou !