chore: update workspace dependencies and internal docs - #111
Merged
Conversation
Copilot started reviewing on behalf of
Martin Taillefer (geeknoid)
August 28, 2026 19:18
View session
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ox-tools workspace to newer dependency/tooling versions, migrates cargo-aprz-lib from cel-interpreter to cel, and refactors README generation to use a single anvil-managed path across library/proc-macro/bin crates (including opting specific internal crates out of generation while keeping stability-warning READMEs).
Changes:
- Bump workspace dependencies and pinned developer tools (including
cargo-deny,cargo-doc2readme,cargo-llvm-cov,cargo-mutants,cargo-nextest,cargo-semver-checks,just, andsccache). - Replace
cel-interpreterwithceland remove the now-obsoletepasteadvisory ignore. - Unify README generation/checking via
_anvil-readme, extend it to bin-only crates, and disable README auto-generation for internalcargo-gamma*implementation crates while hiding their rustdoc.
Reviewed changes
Copilot reviewed 41 out of 42 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| justfiles/basic.just | Route readme / readme-check through anvil’s unified README recipe. |
| justfiles/anvil/versions.just | Bump pinned cargo tool versions used by anvil recipes. |
| justfiles/anvil/checks/readme-check.just | Update README generation policy (lib/proc-macro preferred; bin fallback) and add _anvil-readme helper. |
| deny.toml | Remove paste advisory ignore (no longer needed after CEL swap). |
| crates/cargo-heather/README.md | Regenerated README metadata due to doc2readme/tooling updates. |
| crates/cargo-gamma-unsafe/README.md | Replace generated README with explicit stability warning text. |
| crates/cargo-gamma-unsafe/docs/DESIGN.md | Document stability expectations and hidden rustdoc posture. |
| crates/cargo-gamma-unsafe/Cargo.toml | Opt out of README generation via package.metadata.ox-gen-readme. |
| crates/cargo-gamma-rt/src/lib.rs | Hide rustdoc for internal runtime crate. |
| crates/cargo-gamma-rt/README.md | Replace generated README with explicit stability warning text. |
| crates/cargo-gamma-rt/docs/DESIGN.md | Note hidden rustdoc + stability warning README. |
| crates/cargo-gamma-rt/Cargo.toml | Opt out of README generation via package.metadata.ox-gen-readme. |
| crates/cargo-gamma-process/README.md | Replace generated README with explicit stability warning text. |
| crates/cargo-gamma-process/docs/DESIGN.md | Clarify stability posture and hidden rustdoc + README warning. |
| crates/cargo-gamma-process/Cargo.toml | Opt out of README generation via package.metadata.ox-gen-readme. |
| crates/cargo-gamma-lib/README.md | Replace generated README with explicit stability warning text. |
| crates/cargo-gamma-lib/docs/DESIGN.md | Clarify stability posture and hidden rustdoc + README warning. |
| crates/cargo-gamma-lib/Cargo.toml | Opt out of README generation via package.metadata.ox-gen-readme. |
| crates/cargo-gamma-engine/src/ops/collect/defaults.rs | Adjust syn AST handling for updated syn structures (incl. added fields in tests). |
| crates/cargo-gamma-engine/src/ops/collect/collector/values.rs | Update syn AST test construction for new required fields. |
| crates/cargo-gamma-engine/src/ops/collect/collector/types.rs | Update syn AST test construction for new required fields. |
| crates/cargo-gamma-engine/src/ops/collect/collector.rs | Update match-guard handling to new syn pattern representation. |
| crates/cargo-gamma-engine/README.md | Replace generated README with explicit stability warning text. |
| crates/cargo-gamma-engine/docs/DESIGN.md | Clarify stability posture and hidden rustdoc + README warning. |
| crates/cargo-gamma-engine/Cargo.toml | Opt out of README generation via package.metadata.ox-gen-readme. |
| crates/cargo-gamma-attrs-impl/src/lib.rs | Hide rustdoc for internal implementation crate. |
| crates/cargo-gamma-attrs-impl/README.md | Replace generated README with explicit stability warning text. |
| crates/cargo-gamma-attrs-impl/docs/DESIGN.md | Clarify stability posture and hidden rustdoc + README warning. |
| crates/cargo-gamma-attrs-impl/Cargo.toml | Opt out of README generation via package.metadata.ox-gen-readme. |
| crates/cargo-coverage-gate/README.md | Regenerated README metadata due to doc2readme/tooling updates. |
| crates/cargo-aprz-lib/src/facts/codebase/source_file_analyzer.rs | Minor refactor to match updated text API usage. |
| crates/cargo-aprz-lib/src/expr/expression.rs | Switch CEL import to cel::Program. |
| crates/cargo-aprz-lib/src/expr/evaluator.rs | Switch CEL imports and update clippy expect reasons accordingly. |
| crates/cargo-aprz-lib/Cargo.toml | Replace cel-interpreter dependency with cel. |
| crates/cargo-anvil/templates/justfiles/anvil/versions.just | Keep anvil template pinned tool versions in sync with workspace. |
| crates/cargo-anvil/templates/justfiles/anvil/checks/readme-check.just | Keep anvil template README policy in sync with workspace. |
| crates/cargo-anvil/README.md | Regenerated README metadata due to doc2readme/tooling updates. |
| crates/cargo-anvil/docs/design/checks.md | Update documented README check policy to match new selection path. |
| crates/cargo-anvil/Cargo.toml | Adjust sha2 dependency spec to workspace shorthand. |
| constants.env | Bump pinned tool versions used by workflows/just recipes. |
| Cargo.toml | Update workspace dependency versions; migrate cel-interpreter → cel. |
| Cargo.lock | Refresh lockfile for all dependency/tooling bumps and CEL swap. |
Suppressed comments (2)
justfiles/anvil/checks/readme-check.just:77
_anvil-readmecan run in generate mode, but this opt-out log line is always prefixed withanvil-readme-check, which is confusing when invoked viajust readme. Consider using a mode-agnostic prefix (or incorporatingmode).
crates/cargo-anvil/templates/justfiles/anvil/checks/readme-check.just:77_anvil-readmecan run in generate mode, but this opt-out log line is always prefixed withanvil-readme-check, which is confusing when invoked viajust readme. Consider using a mode-agnostic prefix (or incorporatingmode).
Write-Host "anvil-readme-check: $name (opted out via [package.metadata.ox-gen-readme])"
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Martin Taillefer (geeknoid)
force-pushed
the
fixes
branch
from
August 28, 2026 19:41
d118a5b to
18be88f
Compare
Copilot started reviewing on behalf of
Martin Taillefer (geeknoid)
August 28, 2026 19:42
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 46 out of 47 changed files in this pull request and generated 3 comments.
Suppressed comments (2)
justfiles/anvil/checks/readme-check.just:75
- The
Write-Hostprefixes use a backtick-escaped:(e.g."anvil-readme-$action: ...") to avoid$action:being parsed as a scoped variable. Using${action}` is clearer and avoids relying on escape semantics; it also makes it easier to reuse the same prefix pattern elsewhere in this helper.
crates/cargo-anvil/templates/justfiles/anvil/checks/readme-check.just:75 - The template uses backtick-escaped
:inWrite-Host(e.g."anvil-readme-$action: ...") to avoid$action:being parsed as a scoped variable.${action}` is clearer and avoids relying on escape semantics; it also keeps the template easier to maintain when copied into generated repos.
if ($p.publish -is [array] -and $p.publish.Count -eq 0) {
Write-Host "anvil-readme-$action`: $name (skipped: publish = false)"
continue
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (97.7%) is below the target coverage (100.0%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
=====================================
Coverage 97.7% 97.7%
=====================================
Files 286 286
Lines 62179 62257 +78
=====================================
+ Hits 60755 60832 +77
- Misses 1424 1425 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Martin Taillefer (geeknoid)
force-pushed
the
fixes
branch
from
August 29, 2026 16:52
18be88f to
966ef78
Compare
Copilot started reviewing on behalf of
Martin Taillefer (geeknoid)
August 29, 2026 16:52
View session
Martin Taillefer (geeknoid)
force-pushed
the
fixes
branch
from
August 29, 2026 16:53
966ef78 to
01b88f0
Compare
Copilot started reviewing on behalf of
Martin Taillefer (geeknoid)
August 29, 2026 16:58
View session
|
Martin Taillefer (geeknoid)
force-pushed
the
fixes
branch
from
August 29, 2026 17:26
01b88f0 to
7a8fddb
Compare
Copilot started reviewing on behalf of
Martin Taillefer (geeknoid)
August 29, 2026 17:26
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 49 out of 50 changed files in this pull request and generated no new comments.
Suppressed comments (9)
crates/cargo-anvil/tests/snapshots/snapshots__local_only.snap:2905
- Snapshot is missing the new
$prefixvariable added to_anvil-readme; without it, later${prefix}: ...diagnostics in the template won't match the recorded snapshot.
$check = $action -eq 'check'
crates/cargo-anvil/tests/snapshots/snapshots__local_only.snap:2921
- Snapshot still expects the old mode-agnostic cargo-metadata failure message. The template now uses a mode-aware
${prefix}; the snapshot should be updated to match.
if ($LASTEXITCODE -ne 0) {
Write-Error 'anvil-readme-check: cargo metadata failed'
exit $LASTEXITCODE
}
crates/cargo-anvil/tests/snapshots/snapshots__local_only.snap:2937
- Snapshot still records per-crate status output using
$action(with an escaped colon) instead of the new${prefix}: ...form, so it will drift from the updated_anvil-readmeimplementation.
if ($p.publish -is [array] -and $p.publish.Count -eq 0) {
Write-Host "anvil-readme-$action`: $name (skipped: publish = false)"
continue
}
$disabled = $false
crates/cargo-anvil/tests/snapshots/snapshots__github_backend.snap:4032
- Snapshot is missing the new
$prefixvariable added to_anvil-readme; without it, later${prefix}: ...diagnostics in the template won't match the recorded snapshot.
$check = $action -eq 'check'
crates/cargo-anvil/tests/snapshots/snapshots__github_backend.snap:4048
- Snapshot still expects the old mode-agnostic cargo-metadata failure message. The template now uses a mode-aware
${prefix}; the snapshot should be updated to match.
if ($LASTEXITCODE -ne 0) {
Write-Error 'anvil-readme-check: cargo metadata failed'
exit $LASTEXITCODE
}
crates/cargo-anvil/tests/snapshots/snapshots__github_backend.snap:4064
- Snapshot still records per-crate status output using
$action(with an escaped colon) instead of the new${prefix}: ...form, so it will drift from the updated_anvil-readmeimplementation.
if ($p.publish -is [array] -and $p.publish.Count -eq 0) {
Write-Host "anvil-readme-$action`: $name (skipped: publish = false)"
continue
}
$disabled = $false
crates/cargo-anvil/tests/snapshots/snapshots__ado_backend.snap:4153
- Snapshot is missing the new
$prefixvariable added to_anvil-readme; without it, later${prefix}: ...diagnostics in the template won't match the recorded snapshot.
$check = $action -eq 'check'
crates/cargo-anvil/tests/snapshots/snapshots__ado_backend.snap:4169
- Snapshot still expects the old mode-agnostic cargo-metadata failure message. The template now uses a mode-aware
${prefix}; the snapshot should be updated to match.
if ($LASTEXITCODE -ne 0) {
Write-Error 'anvil-readme-check: cargo metadata failed'
exit $LASTEXITCODE
}
crates/cargo-anvil/tests/snapshots/snapshots__ado_backend.snap:4185
- Snapshot still records per-crate status output using
$action(with an escaped colon) instead of the new${prefix}: ...form, so it will drift from the updated_anvil-readmeimplementation.
if ($p.publish -is [array] -and $p.publish.Count -eq 0) {
Write-Host "anvil-readme-$action`: $name (skipped: publish = false)"
continue
}
$disabled = $false
Martin Taillefer (geeknoid)
force-pushed
the
fixes
branch
from
August 29, 2026 18:02
7a8fddb to
0fafa4e
Compare
Copilot started reviewing on behalf of
Martin Taillefer (geeknoid)
August 29, 2026 18:02
View session
Martin Taillefer (geeknoid)
force-pushed
the
fixes
branch
from
August 30, 2026 00:06
0fafa4e to
932895d
Compare
Copilot started reviewing on behalf of
Martin Taillefer (geeknoid)
August 30, 2026 00:06
View session
Copilot started reviewing on behalf of
Martin Taillefer (geeknoid)
August 30, 2026 01:07
View session
Martin Taillefer (geeknoid)
force-pushed
the
fixes
branch
from
August 30, 2026 01:38
c36fb67 to
1ea0257
Compare
Copilot started reviewing on behalf of
Martin Taillefer (geeknoid)
August 30, 2026 01:38
View session
Martin Taillefer (geeknoid)
force-pushed
the
fixes
branch
from
August 30, 2026 02:20
1ea0257 to
706a654
Compare
Copilot started reviewing on behalf of
Martin Taillefer (geeknoid)
August 30, 2026 02:21
View session
Martin Taillefer (geeknoid)
enabled auto-merge (squash)
August 30, 2026 03:54
Sander Saares (sandersaares)
approved these changes
Aug 31, 2026
Refresh workspace dependencies and pinned development tools, including the migration from cel-interpreter to cel, and adapt affected APIs. Unify README generation and checking, preserve cargo-gamma process and unsafe-boundary rationale in design docs, explain mutation exclusions and the CodeQL parser pin, and remove the obsolete cargo-workspaces installation. Keep incremental cache locks alive from cache adoption through workspace preparation, with command-level concurrency coverage that proves contention and subsequent release. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 52e352a5-2ebd-47c9-9a63-0bc23be56154
Martin Taillefer (geeknoid)
force-pushed
the
fixes
branch
from
August 31, 2026 11:06
706a654 to
b228e46
Compare
Copilot started reviewing on behalf of
Martin Taillefer (geeknoid)
August 31, 2026 11:08
View session
martin-kolinek
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cel-interpreterwithceland remove the obsoletepasteadvisory exceptionValidation
cargo check --workspace --all-targets --all-features --lockedjust readme-checkjust spellcheckjust denycargo sort --workspace --grouped --check --check-format