fix(cargo-anvil): shorten Windows coverage paths - #165
Closed
martintmk wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 460b188a-08ea-418c-802a-41d557329876
Member
Author
|
replaced by #166 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target/cas cargo-llvm-cov's private build directory on Windows unless the caller already setCARGO_LLVM_COV_TARGET_DIR--objectpath passed tollvm-cov exportMotivation
Oxidizer PR microsoft/oxidizer#722 still fails after the per-feature split because one
llvm-cov exportcommand is 34,152 characters, exceeding the Windows CreateProcess limit. Replacingtarget/llvm-cov-targetwithtarget/cin that captured command reduces it to approximately 28,088 characters while preserving the same object set and coverage semantics.This is intentionally a targeted mitigation for cargo-llvm-cov's current one-argument-per-object behavior. A response-file implementation in cargo-llvm-cov would be the structural upstream fix.
Validation