Open
Conversation
…aceEventParser The ApplicationServerTraceEventParser had event ID constants defined for WCF infrastructure events (57394-57410) but no corresponding event handler properties or template entries in EnumerateTemplates(). This caused these events to display as 'EventID(57394)' etc. instead of their proper names like 'HandledException' and 'ThrowingEtwException'. Added 16 missing event handler properties and template registrations for: - HandledException (57394), ShipAssertExceptionMessage (57395), ThrowingException (57396), UnhandledException (57397) - TraceCodeEventLog* variants (57399-57403) - HandledExceptionWarning/Error/Verbose (57404-57406) - ThrowingExceptionVerbose (57407), EtwUnhandledException (57408) - ThrowingEtwExceptionVerbose (57409), ThrowingEtwException (57410) Template types and field definitions were matched to the WCF ETW manifest (Microsoft-Windows-Application Server-Applications provider). Also registered ApplicationServerTraceEventParser as a standard parser in TraceLog so that PerfView's ETLX conversion picks up these templates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
brianrob
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
ApplicationServerTraceEventParserhad event ID constants defined for 16 WCF infrastructure events (57394–57410) but was missing the corresponding event handler properties and template entries inEnumerateTemplates(). This caused these events to display asEventID(57394)etc. instead of their proper names likeHandledExceptionandThrowingEtwException.Additionally,
ApplicationServerTraceEventParserwas not registered as a standard parser inTraceLog, so PerfView's ETLX conversion/read path never instantiated it.Changes
ApplicationServerTraceEventParser.csAdded 16 missing event handler properties and template registrations for:
HandledException(57394),ShipAssertExceptionMessage(57395),ThrowingException(57396),UnhandledException(57397)TraceCodeEventLog*variants (57399–57403)HandledExceptionWarning/Error/Verbose(57404–57406)ThrowingExceptionVerbose(57407),EtwUnhandledException(57408)ThrowingEtwExceptionVerbose(57409),ThrowingEtwException(57410)Template types and field definitions were matched to the WCF ETW manifest (
Microsoft-Windows-Application Server-Applicationsprovider).TraceLog.csRegistered
ApplicationServerTraceEventParserinRegisterStandardParsers()so PerfView resolves these event names when reading ETLX files.Testing
TraceLog.OpenOrConvert(PerfView's code path) — events 57394 and 57410 now resolve asHandledExceptionandThrowingEtwExceptionwith proper payload fields