Fix unit tests by disabling background worker during pgrx tests - #12
Conversation
Co-authored-by: pinodeca <32303022+pinodeca@users.noreply.github.com>
|
Copilot I noticed you did not actually run the unit tests, please do so now, start by running just 1 and fixing it, then fix some more, than run them all. |
Unit tests verified locally - all passing! Test Results:
The 16 ignored tests are E2E tests that require The fix is working as expected - background worker is disabled during unit tests via Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
Now the format checks, clippy, and unit tests (scripts/test-unit.sh) are passing, as are most of the e2e tests (scripts/test-e2e-local.sh). However, one of the e2e tests failed in CI: 25_extension_creation_security Go ahead and debug/fix that. Make sure all e2e tests pass. |
Add 1-second delay after worker table initialization to avoid migration conflicts when client connects. The race condition occurred when: 1. Background worker initializes duroxide-pg tables 2. Client session calls df.start() and creates its own PostgresProvider 3. Both try to run migrations concurrently, causing duplicate key errors Tests fixed: 25_extension_creation_security, 26_drop_create_loop Co-authored-by: pinodeca <32303022+pinodeca@users.noreply.github.com>
Fixed in commit bbee264. The test failure was caused by a race condition during extension drop/recreate: Root Cause: Fix: Verified:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
98ff337
into
pinodeca/gucs
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.