Update security spec to reflect implemented sqlx approach - #45
Merged
Conversation
- spec-security-model.md: Replace SPI + SetUserIdAndSecContext references with the implemented sqlx per-user connection approach (connect_as_user with login_role/submitted_by) - Add Section 8.8 analyzing SPI as a potential future optimization - Update T0 mitigation: GetOuterUserId() handles SECURITY DEFINER - Correct df.in_workflow docs: only guards variable mutations, does not yet prevent recursive df.start() - Update user-isolation.md, user-isolation-review.md, types.rs to match corrected df.in_workflow behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
spec-security-model.mdto reflect the actual implemented user isolation approach (sqlx per-user connections) rather than the originally-proposed SPI +SetUserIdAndSecContext()approach.Also corrects the documentation of
df.in_workflowacross all docs and source code.Changes
SetUserIdAndSecContextreferences with the implemented sqlx per-user connection approach (connect_as_userwithlogin_role/submitted_by)GetOuterUserId()correctly handles SECURITY DEFINER (captures caller, not definer) — residual risk reduced from High to Lowsetvar/unsetvar/clearvars), not recursivedf.start()— noted as potential future improvementuser-isolation.md,user-isolation-review.md,src/types.rsto match