fix: replace fixed sleep with polling loop in test 22 to fix CI race condition - #48
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a CI race condition in E2E test 22 (cross_connection.sql) where a fixed pg_sleep(2) was insufficient on slower CI runners, causing the test to fail because the background worker hadn't committed the first loop iteration INSERT yet.
Changes:
- Replaces
SELECT pg_sleep(2)with a polling loop (up to ~10s, checking every 100ms) that waits forcross_conn_logto contain at least oneloop_iterationrow before proceeding with assertions. - Updates the failure error message to mention the timeout context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test 22 (cross_connection) was flaky in CI because it used a fixed
pg_sleep(2)before asserting that the loop had completed at least one iteration. On slower CI runners, the background worker hadn't committed the INSERT yet.Fix: Replace the fixed sleep + immediate check with a polling loop that waits up to 10s for the first loop iteration row to appear in
cross_conn_log.