-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: load event with non-url subframe #13340
fix: load event with non-url subframe #13340
Conversation
ca0358f
to
61cea01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice find, thank you for the PR! However, both linked issues are Firefox-specific, so I believe the proper fix would be in Firefox instrumentation that does not send any load/domcontentloaded events. Adding @aslushnikov for any ideas.
Thanks for your review! It seems that it's not just firefox that has the problem. Although only changing firefox can solve these two issues, the three browsers have not been able to pass the test completely before. Firefox, webkit, and chrome are all inconsistent for javascript|text/html frame loading events. And it looks like not waiting for non-url frames has little effect on behavior, so I went with this solution. |
Hello, can I download the latest package to solve this problem, or change my case according to your code |
This pr has not been merged yet. You can cherry-pick and build it yourself. Or modify the files in node_module. |
@liuxingbaoyu thank you for the PR and awesome tests. So indeed each browser struggles differently. Here's the summary:
Let me see if it's worth fixing upstream in browsers or on our side. |
|
My node_module There is no playwright-core package in the module file |
After changing according to your idea, my original case can't run. Have you encountered this problem |
Most of these issues have been fixed, thank you for the PR! |
fixes: #12182
fixes: #9028