fix: load event with non-url subframe

packages/playwright-core/src/server/frames.ts

@@ -551,7 +551,9 @@ export class Frame extends SdkObject {
       // We require a particular lifecycle event to be fired in the whole
       // frame subtree, and then consider it done.
       for (const event of events) {
-        if (!child._subtreeLifecycleEvents.has(event))
+        // Wait for commit in the subframe with non-url src instead of other events
+        // <iframe src="javascript:false"></iframe> <iframe src="data:text/html"></iframe>
+        if (!child._subtreeLifecycleEvents.has(child._url === '' ? 'commit' : event))
           events.delete(event);
       }
     }

tests/assets/data-src-frame.html

@@ -0,0 +1 @@
+<iframe src="data:text/html"></iframe>

tests/assets/javascript-src-frame.html

@@ -0,0 +1 @@
+<iframe src="javascript:false"></iframe>

tests/library/browsercontext-page-event.spec.ts

@@ -199,3 +199,31 @@ it('should not hang on ctrl-click during provisional load', async ({ context, pa
   ]);
   expect(popup).toBeTruthy();
 });
+
+it('should work with javascript-src-frame', async ({ browser, server }) => {
+  const context = await browser.newContext();
+  const page = await context.newPage();
+
+  await page.goto(server.PREFIX + '/javascript-src-frame.html', { waitUntil: 'commit' });
+
+  await page.waitForLoadState('networkidle');
+  await page.waitForLoadState('domcontentloaded');
+  await page.waitForLoadState('load');
+
+  expect(page.url()).not.toBe('');
+  await context.close();
+});
+
+it('should work with data-src-frame', async ({ browser, server }) => {
+  const context = await browser.newContext();
+  const page = await context.newPage();
+
+  await page.goto(server.PREFIX + '/data-src-frame.html', { waitUntil: 'commit' });
+
+  await page.waitForLoadState('networkidle');
+  await page.waitForLoadState('domcontentloaded');
+  await page.waitForLoadState('load');
+
+  expect(page.url()).not.toBe('');
+  await context.close();
+});