-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat: add failOnStatusCode option to API request context #34346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
… Include flag for BrowserContext
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @JacksonLei123! The code looks generally good, but CI is failing because there's a mismatch in the generated files. Could you run |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Yury Semikhatsky <[email protected]> Signed-off-by: JacksonLei123 <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"9 flaky37883 passed, 654 skipped Merge workflow run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should probably be renamed in accord with the new name of the property.
Add failOnStatusCode option to API request context so that the flag is applied to every request made unless specified.
References issue #34204