Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chromium-tip-of-tree): roll to r1295 #34372

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Jan 17, 2025

The following tests are failing due to https://chromium-review.googlesource.com/c/chromium/src/+/6175333, which made Page.frameScheduledNavigation arrive much later after a click, breaking our navigation autowaiting after click.

❌ [chromium-library] › tests/library/har.spec.ts:179:3 › should include form params @ubuntu-20.04-chromium-tip-of-tree
❌ [chromium-page] › tests/page/page-autowaiting-basic.spec.ts:58:3 › should await form-get on click @ubuntu-20.04-chromium-tip-of-tree
❌ [chromium-page] › tests/page/page-autowaiting-basic.spec.ts:79:3 › should await form-post on click @ubuntu-20.04-chromium-tip-of-tree
❌ [chromium-page] › tests/page/page-network-request.spec.ts:288:3 › should parse the data if content-type is application/x-www-form-urlencoded @ubuntu-20.04-chromium-tip-of-tree
❌ [chromium-page] › tests/page/page-set-input-files.spec.ts:521:3 › should detect mime type @ubuntu-20.04-chromium-tip-of-tree

Decided to disable DeferRendererTasksAfterInput feature for now.

@dgozman dgozman added the CQ1 label Jan 17, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@dgozman dgozman force-pushed the roll-chromium-tot-1295 branch from 2bc4b02 to 35aabcd Compare January 17, 2025 14:38
Copy link
Contributor

Test results for "tests 1"

7 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [installation tests] › tests/playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-macos-latest
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsertype-connect.spec.ts:898:7 › run-server › socks proxy › should check proxy pattern on the client @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:109:1 › should show tracing.group in the action list with location @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:245:3 › should upload large file with relative path @webkit-ubuntu-22.04-node18

37596 passed, 648 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman added CQ1 and removed CQ1 labels Jan 17, 2025
Copy link
Contributor

Test results for "tests others"

21498 passed, 503 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

Test results for "tests 2"

1 fatal errors, not part of any test
9 failed
❌ [chromium-library] › tests/library/proxy.spec.ts:146:3 › should work with authenticate followed by redirect @chrome-macos-latest
❌ [chromium-library] › tests/library/proxy.spec.ts:178:3 › should exclude patterns @chrome-macos-latest
❌ [chromium-library] › tests/library/proxy.spec.ts:228:3 › should use socks proxy @chrome-macos-latest
❌ [chromium-library] › tests/library/downloads-path.spec.ts:63:5 › downloads path › should report downloads in downloadsPath folder @msedge-beta-macos-latest
❌ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-beta-macos-latest
❌ [chromium-library] › tests/library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-beta-macos-latest
❌ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should --save-trace @msedge-macos-latest
❌ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge
❌ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge

101 flaky ⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:383:5 › run-server › should emit close events on pages and contexts @channel-chromium-macos-latest
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:867:7 › run-server › socks proxy › should proxy based on the pattern @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should --save-trace @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/logger.spec.ts:19:3 › should log @smoke @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-3.spec.ts:578:7 › cli codegen › should generate getByLabel @chrome-beta-windows-latest
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @chrome-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:397:5 › run-server › should terminate network waiters @chrome-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:436:5 › run-server › should respect selectors @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should --save-trace @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest
⚠️ [chromium-library] › tests/library/proxy.spec.ts:44:3 › should use proxy for second page @chrome-macos-latest
⚠️ [chromium-library] › tests/library/proxy.spec.ts:238:3 › should use socks proxy in second page @chrome-macos-latest
⚠️ [chromium-library] › tests/library/tracing.spec.ts:209:5 › should respect tracesDir and name @chrome-macos-latest
⚠️ [chromium-library] › tests/library/tracing.spec.ts:370:5 › should survive browser.close with auto-created traces dir @chrome-macos-latest
⚠️ [chromium-library] › tests/library/selector-generator.spec.ts:121:5 › selector generator › should not use text for select @chrome-windows-latest
⚠️ [chromium-library] › tests/library/inspector/console-api.spec.ts:78:3 › should support playwright.locator({ hasNot }) @chromium-headed-windows-latest
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1298:1 › should pick locator in iframe @chromium-macos-13-large
⚠️ [chromium-page] › tests/page/page-screenshot.spec.ts:650:5 › page screenshot animations › should stop animations that happen right before screenshot @chromium-tip-of-tree-macos-13--headed
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:529:5 › pause › should record from debugger @chromium-tip-of-tree-ubuntu-20.04--headed
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-3.spec.ts:222:7 › cli codegen › should generate frame locators (4) @chromium-tip-of-tree-windows-latest
⚠️ [chromium-library] › tests/library/selector-generator.spec.ts:244:5 › selector generator › should separate selectors by >> @chromium-tip-of-tree-windows-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chromium-windows-latest
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-ubuntu-20.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-windows-latest
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › tests/library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-ubuntu-24.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › tests/library/browsercontext-cookies.spec.ts:112:3 › should get multiple cookies @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/browsercontext-set-extra-http-headers.spec.ts:20:3 › should override extra headers from browser context @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/selector-generator.spec.ts:244:5 › selector generator › should separate selectors by >> @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/trace-viewer.spec.ts:1146:1 › should pick locator @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/trace-viewer.spec.ts:1336:1 › should highlight locator in iframe while typing @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/video.spec.ts:580:5 › screencast › should capture static page in persistent context @smoke @firefox-headed-windows-latest
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large
⚠️ [firefox-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @firefox-macos-13-large
⚠️ [firefox-page] › tests/page/elementhandle-screenshot.spec.ts:121:5 › element screenshot › should scroll element into view @firefox-macos-13-large
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-13-large
⚠️ [firefox-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @firefox-macos-13-xlarge
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-14-large
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-xlarge
⚠️ [firefox-library] › tests/library/page-clock.spec.ts:264:3 › stubTimers › replaces global performance.now @firefox-ubuntu-20.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-20.04
⚠️ [firefox-page] › tests/page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy @firefox-ubuntu-20.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-24.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-windows-latest
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:172:5 › launchServer › should ignore page.pause when headed @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:107:3 › should accept objects as options @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should --save-trace @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-20.04
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should --save-trace @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:463:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-20.04
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:43:5 › launch server › should work with wsPath @msedge-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:463:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @msedge-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-macos-latest
⚠️ [chromium-library] › tests/library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-20.04
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:264:3 › should isolate proxy credentials between contexts @msedge-windows-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click @msedge-windows-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:24:7 › cli codegen › should contain open page @msedge-windows-latest
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @tracing-firefox
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:87:5 › mobile viewport › should support window.orientation emulation @tracing-webkit
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @webkit-headed-macos-14-xlarge
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-ubuntu-20.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:268:7 › cli codegen › should fill @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:578:7 › cli codegen › should uncheck @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:636:7 › cli codegen › should consume pointer events @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:866:7 › cli codegen › should click button with nested div @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:929:7 › cli codegen › should clear when recording is disabled @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:25:7 › cli codegen › should click locator.first @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:607:7 › cli codegen › should generate getByLabel without regex @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:784:7 › cli codegen › should assert value on disabled input @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/tap.spec.ts:22:3 › should send all of the correct events @smoke @webkit-headed-windows-latest
⚠️ [webkit-page] › tests/page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:116:5 › mobile viewport › default mobile viewports to 980 width @webkit-ubuntu-20.04
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:77:14 › page screenshot › should work with device scale factor @webkit-ubuntu-20.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-python.spec.ts:133:5 › should work with --save-har @webkit-ubuntu-24.04
⚠️ [webkit-library] › tests/library/har.spec.ts:441:3 › should return receive time @webkit-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:33:5 › should print the correct context options when using a device and lang @webkit-windows-latest

254122 passed, 9737 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants