Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve network tabs trace viewer #35298

Closed
wants to merge 4 commits into from

Conversation

cpAdm
Copy link
Contributor

@cpAdm cpAdm commented Mar 20, 2025

Improvements to network resources tabs:

  • Updated tab names/layout to be more in line with popular devtools
  • Sections inside a tab can be collapsed (and is remember in storage)
  • Copy buttons are now more visible inside a dropdown in the toolbar
  • key-values can now easier be distinguished by the new spacing

Current situation:
Image

After:
afbeelding

Closes: #35214

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpAdm Thank you for the PR! Unfortunately, I find it very hard to review. For some reason, components moved around which makes the diff very large. The PR seems to do multiple things, and I'm not sure what change does what.

Could you please make a small PR focused on a single thing? I think that would be easier to iterate on. Thank you!

@cpAdm
Copy link
Contributor Author

cpAdm commented Mar 24, 2025

@dgozman I am used to define my sub-components before I use them. That's why I moved many around, but it does indeed make the PR harder.

I still have to move stuff like setRequestBody/setResponseBody since the copy buttons have moved to the toolbar.

I hope the PR is more readable now. Possibly the only thing I could still do to make it more readable is splitting the PR in 2:

  1. first moving the copy buttons,
  2. the rest

Copy link
Contributor

Test results for "tests 1"

2 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node18-1

38815 passed, 809 skipped
✔️✔️✔️

Merge workflow run.

@cpAdm cpAdm marked this pull request as draft March 26, 2025 12:20
@cpAdm cpAdm closed this Mar 26, 2025
@cpAdm
Copy link
Contributor Author

cpAdm commented Mar 27, 2025

@dgozman Created new PR for the 'copy buttons' part #35366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Improve network tabs naming in Trace Viewer
2 participants