Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bidi): hardcode "default" id for persistent context #35303

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Mar 20, 2025

According to https://w3c.github.io/webdriver-bidi/#default-user-context, it is always "default".

This comment has been minimized.

@yury-s yury-s merged commit b9ccc5b into microsoft:main Mar 20, 2025
23 of 25 checks passed
@yury-s yury-s deleted the bidi-default-context-id-const branch March 20, 2025 20:42
Copy link
Contributor

Test results for "tests 1"

4 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:565:7 › page screenshot › mask option › should hide elements based on attr @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

38796 passed, 808 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants