Skip to content

Conversation

@cpAdm
Copy link
Contributor

@cpAdm cpAdm commented Nov 18, 2025

  • Document theme (dark/light) listens to system's theme if user's theme is 'system'
  • Changed all darkmode checkboxes to select inputs
  • Added some stricter typing to settingsView.tsx and uiUtils.ts::Settings
  • Moved the HeaderView settings dialog outside the button, this was intercepting events for the select
  • Changed existing dark mode test, and added another for system theme change
Inspector HTML reporter Trace viewer UI mode
image
image
image
image
image
image
image
image

Closes: #37874

@cpAdm cpAdm requested a review from pavelfeldman November 19, 2025 14:25
@github-actions
Copy link
Contributor

Test results for "MCP"

2432 passed, 116 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "tests 1"

6 failed
❌ [playwright-test] › ui-mode-test-output.spec.ts:35 › should work after theme switch @macos-latest-node18-2
❌ [playwright-test] › ui-mode-test-output.spec.ts:35 › should work after theme switch @ubuntu-latest-node18-2
❌ [playwright-test] › ui-mode-test-output.spec.ts:35 › should work after theme switch @ubuntu-latest-node20-2
❌ [playwright-test] › ui-mode-test-output.spec.ts:35 › should work after theme switch @ubuntu-latest-node22-2
❌ [playwright-test] › ui-mode-test-output.spec.ts:35 › should work after theme switch @ubuntu-latest-node24-2
❌ [playwright-test] › ui-mode-test-output.spec.ts:35 › should work after theme switch @windows-latest-node18-2

4 flaky ⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-node24`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-event-request.spec.ts:182 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node18`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:397 › should work behind reverse proxy `@macos-latest-node18-2`

39454 passed, 784 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: UI does not change theme whenever system changes theme

2 participants