feat(ui-mode): add accept snapshots button #38321
Open
+393
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to accept snapshot updates directly from UI mode: - Add "Accept snapshots" button per test/group when snapshot errors are present - Add "Accept all snapshots" button in toolbar to accept all snapshot errors at once - Implement acceptSnapshots API in test server to copy actual to expected snapshots - Support both screenshot snapshots (via attachments) and text snapshots (via matcherResult) - Show compact toast notification with slide-in animation and click-to-dismiss - Execute snapshot acceptance immediately (not queued) to work while tests are running - Hide buttons when no snapshot errors present instead of showing disabled state - Add comprehensive test coverage for the new API This allows developers to quickly update snapshots from failed tests without switching to the command line, improving the UI mode workflow.
Author
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds snapshot acceptance functionality to UI Mode, allowing developers to accept snapshot updates directly from the UI without switching to the command line and running
--update-snapshots.Features
Screenshot
Related Issues
Fixes #24310