Skip to content

chore: swallow TargetClosedErrors in beforeunload dialog.dismiss() #39788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgozman merged 1 commit into from
Mar 25, 2026
+8 −11
Merged

chore: swallow TargetClosedErrors in beforeunload dialog.dismiss() #39788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/playwright-core/src/client/dialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import { ChannelOwner } from './channelOwner';
import { Page } from './page';
import { isTargetClosedError } from './errors';

import type * as api from '../../types/types';
import type * as channels from '@protocol/channels';
Expand Down Expand Up @@ -56,6 +57,12 @@ export class Dialog extends ChannelOwner<channels.DialogChannel> implements api.
}

async dismiss() {
await this._channel.dismiss();
try {
await this._channel.dismiss();
} catch (e) {
if (isTargetClosedError(e))
return;
throw e;
}
}
}
10 changes: 0 additions & 10 deletions tests/library/page-close.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,6 @@ test('should close page with active dialog', async ({ page }) => {
await page.close();
});

test('should not accept dialog after close', async ({ page, mode }) => {
test.fixme(mode.startsWith('service2'), 'Times out');
const promise = page.waitForEvent('dialog');
page.evaluate(() => alert()).catch(() => {});
const dialog = await promise;
await page.close();
const e = await dialog.dismiss().catch(e => e);
expect(e.message).toContain('Target page, context or browser has been closed');
});

test('expect should not print timed out error message when page closes', async ({ page }) => {
await page.setContent('<div id=node>Text content</div>');
const [error] = await Promise.all([
Expand Down
Loading