Skip to content

chore: refactor protocol metainfo for debugger pause and snapshot phases#39806

Closed
pavelfeldman wants to merge 1 commit intomicrosoft:mainfrom
pavelfeldman:refactor-debugger-metainfo
Closed

chore: refactor protocol metainfo for debugger pause and snapshot phases#39806
pavelfeldman wants to merge 1 commit intomicrosoft:mainfrom
pavelfeldman:refactor-debugger-metainfo

Conversation

@pavelfeldman
Copy link
Copy Markdown
Member

Summary

  • Replace pausesBeforeAction/pausesBeforeInput with pause/isAutoWaiting/input fields in protocol metainfo
  • Make snapshot capture phase-aware (before/after/input) for more precise tracing
  • Move getMetainfo from protocolFormatter.ts to protocolMetainfo.ts
  • Refactor debugger pause logic to use new metainfo fields, skip internal calls early

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@pavelfeldman pavelfeldman force-pushed the refactor-debugger-metainfo branch from 7eefb89 to d4d483c Compare March 21, 2026 20:11
@github-actions
Copy link
Copy Markdown
Contributor

Test results for "tests 1"

5 flaky ⚠️ [chromium-library] › library/trace-viewer.spec.ts:1223 › should display language-specific locators `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/popup.spec.ts:261 › should not throw when click closes popup `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/inspector/recorder-api.spec.ts:120 › should type `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1223 › should display language-specific locators `@webkit-ubuntu-22.04-node20`

38816 passed, 845 skipped


Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

Test results for "MCP"

5458 passed, 340 skipped


Merge workflow run.

snapshot: true
pausesBeforeInput: true
pause: true
input: true
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find a single action where input !== isAutoWaiting, and so I am confused about the difference.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keyup, keydown, etc. It is already landed anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants