Skip to content

fix(test): allow any return type for test body#40852

Merged
yury-s merged 3 commits into
microsoft:mainfrom
dword-design:fix-test-body-return-type
May 16, 2026
Merged

fix(test): allow any return type for test body#40852
yury-s merged 3 commits into
microsoft:mainfrom
dword-design:fix-test-body-return-type

Conversation

@dword-design

@dword-design dword-design commented May 14, 2026

Copy link
Copy Markdown
Contributor

Closes #40851

@dword-design

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

Comment thread packages/playwright/types/test.d.ts Outdated
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

…that it can be async

Signed-off-by: Sebastian Landwehr <info@sebastianlandwehr.com>
Signed-off-by: Sebastian Landwehr <info@sebastianlandwehr.com>
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

7086 passed, 1104 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

2 flaky ⚠️ [chromium-library] › library/video.spec.ts:647 › screencast › should capture full viewport `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node24`

41902 passed, 850 skipped


Merge workflow run.

@yury-s yury-s merged commit bb7af07 into microsoft:main May 16, 2026
45 checks passed
@dword-design dword-design deleted the fix-test-body-return-type branch May 18, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: test body doesn't accept function with a return type other than void

2 participants