Skip to content

feat(har): add _resourceType to all requests #41077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcrousso merged 1 commit into from
Jun 1, 2026
Merged

feat(har): add _resourceType to all requests #41077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/playwright-core/src/server/har/harTracer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,7 @@ export class HarTracer {

const pageEntry = this._createPageEntryIfNeeded(page);
const harEntry = createHarEntry(pageEntry?.id, request.method(), url, request.frame()?.guid, this._options);
harEntry._resourceType = request.resourceType();
this._recordRequestHeadersAndCookies(harEntry, request.headers());
harEntry.request.postData = this._postDataForRequest(request, this._options.content);
if (!this._options.omitSizes)
Expand Down
56 changes: 56 additions & 0 deletions tests/library/har.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,6 +964,62 @@ it('should support HAR larger than 512MB', async ({ contextFactory, server, brow
expect(tail.toString()).toMatch(/\}\s*\}\s*$/);
});

it('should record resource type', async ({ contextFactory, server, asset }, testInfo) => {
server.setRoute('/resource-types.html', (req, res) => {
res.writeHead(200, { 'Content-Type': 'text/html' });
res.end(`
<link rel="stylesheet" href="/resource-type-stylesheet.css">
<script src="/resource-type-script.js"></script>
<img src="/resource-type-image.png">
`);
});
server.setRoute('/resource-type-stylesheet.css', (req, res) => {
res.writeHead(200, { 'Content-Type': 'text/css' });
res.end(`
@font-face {
font-family: 'iconfont';
src: url('/resource-type-font.woff2') format('woff2');
}
body { font-family: 'iconfont'; }
`);
});
server.setRoute('/resource-type-font.woff2', (req, res) => {
server.serveFile(req, res, asset('webfont/iconfont.woff2'));
});
server.setRoute('/resource-type-script.js', (req, res) => {
res.writeHead(200, { 'Content-Type': 'application/javascript' });
res.end('window.__loaded = true;');
});
server.setRoute('/resource-type-image.png', (req, res) => {
server.serveFile(req, res, asset('pptr.png'));
});

const { page, getLog } = await pageWithHar(contextFactory, testInfo);
await page.goto(server.PREFIX + '/resource-types.html');
await page.evaluate(() => fetch('/resource-type-fetch').catch(() => {}));
await page.evaluate(() => new Promise<void>(resolve => {
const xhr = new XMLHttpRequest();
xhr.open('GET', '/resource-type-xhr');
xhr.onloadend = () => resolve();
xhr.send();
}));
const log = await getLog();

const typeForURL = log.entries.reduce((accumulator, entry) => {
accumulator[entry.request.url] = entry._resourceType;
return accumulator;
}, {});
expect(typeForURL).toMatchObject({
[server.PREFIX + '/resource-types.html']: 'document',
[server.PREFIX + '/resource-type-stylesheet.css']: 'stylesheet',
[server.PREFIX + '/resource-type-script.js']: 'script',
[server.PREFIX + '/resource-type-image.png']: 'image',
[server.PREFIX + '/resource-type-font.woff2']: 'font',
[server.PREFIX + '/resource-type-fetch']: 'fetch',
[server.PREFIX + '/resource-type-xhr']: 'xhr',
});
});

it.describe('tracing.startHar', () => {
it('should record a HAR with options', async ({ contextFactory, server }, testInfo) => {
const context = await contextFactory();
Expand Down
Loading