Skip to content

chore(mcp): remove dead saveTrace config references #41119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yury-s merged 1 commit into from
Jun 3, 2026
Merged

chore(mcp): remove dead saveTrace config references #41119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions packages/playwright-core/src/tools/backend/context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ export type ContextConfig = {
outputMaxSize?: number;
outputMode?: 'file' | 'stdout';
saveSession?: boolean;
saveTrace?: boolean;
secrets?: Record<string, string>;
snapshot?: {
mode?: 'full' | 'none';
Expand Down Expand Up @@ -327,19 +326,6 @@ export class Context {
const browserContext = this._rawBrowserContext;
await this._setupRequestInterception(browserContext);

if (this.config.saveTrace) {
await browserContext.tracing.start({
name: 'trace-' + Date.now(),
screenshots: true,
snapshots: true,
live: true,
});
this._disposables.push({
dispose: async () => {
await browserContext.tracing.stop();
},
});
}
for (const initScript of this.config.browser?.initScript || [])
this._disposables.push(await browserContext.addInitScript({ path: path.resolve(this.options.cwd, initScript) }));

Expand Down
1 change: 0 additions & 1 deletion packages/playwright-core/src/tools/mcp/configIni.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ const longhandTypes: Record<string, LonghandType> = {
'extension': 'boolean',
'capabilities': 'string[]',
'saveSession': 'boolean',
'saveTrace': 'boolean',
'saveVideo': 'size',
'sharedBrowserContext': 'boolean',
'outputDir': 'string',
Expand Down
4 changes: 2 additions & 2 deletions tests/mcp/config.ini.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,15 +105,15 @@ test('ini config boolean values', async ({ startClient }) => {
const { client } = await startClient({
config: `
capabilities = config
saveTrace = true
saveSession = true
browser.contextOptions.bypassCSP = true
browser.contextOptions.javaScriptEnabled = false
`,
});

const result = await client.callTool({ name: 'browser_get_config' });
const config = JSON.parse(parseResponse(result).result);
expect(config.saveTrace).toBe(true);
expect(config.saveSession).toBe(true);
expect(config.browser.contextOptions.bypassCSP).toBe(true);
expect(config.browser.contextOptions.javaScriptEnabled).toBe(false);
});
Loading