[canvas-apps] Sync prompts from PA-client - #445
Open
Joe Mayo (MSFT) (joem-msft) wants to merge 2 commits into
Open
[canvas-apps] Sync prompts from PA-client#445Joe Mayo (MSFT) (joem-msft) wants to merge 2 commits into
Joe Mayo (MSFT) (joem-msft) wants to merge 2 commits into
Conversation
Copilot started reviewing on behalf of
Joe Mayo (MSFT) (joem-msft)
August 19, 2026 23:49
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the canvas-apps plugin’s skill/agent prompts and reference guidance from the PA-client source, keeping the on-repo instructions aligned with the upstream prompt set used for Canvas App YAML authoring and validation.
Changes:
- Updated
/canvas-apporchestration guidance (working-directory placeholders, builder wave dispatch rules, and post-build validation steps including editor-state handling). - Refreshed reference documentation for Canvas App YAML structure, planning templates, and validation workflow (including component-related guidance and wording normalization).
- Updated agent instructions (
canvas-app-planner,canvas-screen-builder) to match the synced prompt conventions.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/canvas-apps/skills/canvas-app/SKILL.md | Updates top-level orchestration and build/QA handoff instructions. |
| plugins/canvas-apps/references/YamlSyntax.md | Refreshes YAML structure/syntax guidance and adds component-related sections. |
| plugins/canvas-apps/references/ValidationWorkflow.md | Adjusts compile/repair workflow wording and editor-state guidance. |
| plugins/canvas-apps/references/QAChecks.md | Normalizes wording in QA checklist descriptions. |
| plugins/canvas-apps/references/PlanTemplates.md | Updates the canonical plan templates (including editor state changes section). |
| plugins/canvas-apps/references/LayoutGuide.md | Normalizes wording and formatting in responsive-layout guidance. |
| plugins/canvas-apps/references/EditWorkflow.md | Updates edit routing workflow to use working-directory placeholders and refreshed wording. |
| plugins/canvas-apps/references/DesignGuide.md | Minor wording normalization in design guidance. |
| plugins/canvas-apps/references/CreateWorkflow.md | Updates create workflow to use working-directory placeholders and refreshed wording. |
| plugins/canvas-apps/references/ControlGuide.md | Adds/updates guidance sections and normalizes wording. |
| plugins/canvas-apps/agents/canvas-screen-builder.md | Updates builder role instructions and tool naming conventions. |
| plugins/canvas-apps/agents/canvas-app-planner.md | Updates planner instructions (including component refresh checkpoint and editor-state recording). |
Suppressed comments (1)
plugins/canvas-apps/references/YamlSyntax.md:119
- This sentence implies component definitions must live in a
Components/folder, but the same doc’s file-structure section only specifies filenames (and doesn’t establish a required folder layout). Reword this to makeComponents/an example/convention rather than a requirement.
Local component definitions can be authored in the `Components/` folder as `.pa.yaml` files.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+144
to
+146
| - Apply `## Editor State Changes` from `[working directory]/canvas-app-plan.md` to | ||
| `[working directory]/_EditorState.pa.yaml` after all builders finish. If it says `None`, leave the | ||
| file unchanged. |
| - `LayoutOverflowY` — vertical overflow (`Scroll` for scrollable containers) | ||
| - `FillPortions` — proportional sizing | ||
| - `PaddingTop/Bottom/Left/Right` — container padding | ||
| - `PaddingTop`/`Bottom`/`Left`/`Right` — container padding |
Comment on lines
+25
to
+31
| Each '*.pa.yaml' file should contain a single top-level object. These are specified using one of the following top-level keywords: | ||
| - `App` - Represents the 'App' object in the app. The filename for this object should be `App.pa.yaml`. | ||
| - `EditorState` - Controls the Studio ordering of screens and local component definitions through `ScreensOrder` and `ComponentDefinitionsOrder`. Use filename `_EditorState.pa.yaml`. | ||
| - `ComponentDefinitions` - A named-object-mapping of local component definitions. Use filename `<the component's name>.pa.yaml`. | ||
| - `Screens` - A named-object-mapping of screens in the app Use filename `<the screen's name>.pa.yaml`. | ||
|
|
||
| You should ensure each top-level object is placed into its own pa.yaml file, using the correct top-level keyword. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PA-client repo now owns prompts. This is the first PR where we sync them to the canvas-apps plugin.