Bug fix #499
Merged
Bug fix #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: REDMOND\v-bdjalalov <[email protected]>
Signed-off-by: REDMOND\v-bdjalalov <[email protected]>
Signed-off-by: REDMOND\v-bdjalalov <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR is a bug fix release that bumps the version from 3.4.3.0 to 3.4.4.0. It addresses two issues: fixing label colors in high contrast mode and correcting the task sorting logic to properly handle null start/end dates.
Key changes:
- Fixed high contrast mode support by wrapping label colors with
colorHelper.getHighContrastColor() - Refactored task sorting logic to properly separate and handle null
startandenddates - Updated dependencies (glob, js-yaml, node-forge) to newer patch versions
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/gantt.ts | Fixed high contrast label colors and refactored sorting logic to correctly push tasks with null dates to the end |
| pbiviz.json | Bumped visual version and display name from 3.4.3.0 to 3.4.4.0 |
| package.json | Updated package version to 3.4.4.0 |
| package-lock.json | Updated package version and dependency versions (glob, js-yaml, node-forge) |
| CHANGELOG.md | Added 3.4.4 release notes documenting the high contrast mode fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: REDMOND\v-bdjalalov <[email protected]>
Signed-off-by: REDMOND\v-bdjalalov <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: REDMOND\v-bdjalalov <[email protected]>
Demonkratiy
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.