-
Notifications
You must be signed in to change notification settings - Fork 662
Refactor nlp_engine_provider.py to improve configuration handling and… #1559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ShakutaiGit
wants to merge
18
commits into
main
Choose a base branch
from
fix-1556-config-file-missing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… missing config file
… improving error messages for missing fields
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
SharonHart
reviewed
Mar 31, 2025
SharonHart
reviewed
Mar 31, 2025
omri374
reviewed
Apr 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just realized I didn't publish my review
presidio-analyzer/presidio_analyzer/nlp_engine/nlp_engine_provider.py
Outdated
Show resolved
Hide resolved
…rosoft/presidio into fix-1556-config-file-missing
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
SharonHart
previously approved these changes
Apr 22, 2025
omri374
reviewed
Apr 22, 2025
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…-1556-config-file-missing
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error Reporting #1556
In this update, we have:
FileNotFoundError
is raised rather than silently defaulting.default.yaml
), if it’s missing we now log a warning and fall back to an internal built-in default.Change Description
Describe your changes here, for example:
_read_nlp_conf
to raise an exception when a user-provided config file does not exist.FileNotFoundError
for the default config file and use a built-in configuration if it’s missing.Issue Reference
This PR fixes issue #XX
Checklist