Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unified Analyzer Configuration #1970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Unified Analyzer Configuration #1970
Changes from all commits
4fbc51f5f3903066aba7301edd76File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NLP_CONF_FILEandRECOGNIZER_REGISTRY_CONF_FILEare now defaulted to an empty string, but the Dockerfile still unconditionally uses these build args inCOPYinstructions later. With empty defaults, the Docker build will fail when it reaches thoseCOPY ${NLP_CONF_FILE} .../COPY ${RECOGNIZER_REGISTRY_CONF_FILE} ...steps. Either remove those COPY steps entirely, or keep non-empty defaults (and rely on the unified analyzer config taking priority at runtime).Uh oh!
There was an error while loading. Please reload this page.