Add keyboard navigation help documentation #10556
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds three shortcuts to help keyboard users navigate to the editor (workspace), toolbox and trigger the hex download. Co-authored-by: Grace <[email protected]>
microbit-robert
force-pushed
the
keyboard-help-docs
branch
from
aef60c4 to
012c42f
Compare
First cut of changes
- Collapse simulator when navigate region overlay opens - Expand mini sim when region is selected
This uses the sidebar but not the docs system which allows us to pull live shortcut bindings. Particularly useful if we allow custom shortcut bindings going forward. - Moves the tab order of the sidebar docs forward and adds a focus ring. - Handle shortcuts triggered when the sim has focus. - Maximise the mini sim for region nav as it's too small for accessible use. - Added support for escape to close keyboard controls - note this doesn't work for reference docs due to the iframe. Closes microsoft#10556
microbit-matt-hillsdon
force-pushed
the
keyboard-help-docs
branch
from
012c42f to
9799b55
Compare
| * @param modifierNames The names to use for the Meta/Control/Alt modifiers. | ||
| * @returns The formatted shortcuts. | ||
| */ | ||
| function getActionShortcutsAsKeys( |
There was a problem hiding this comment.
This is all a bit gross but matches the keyboard nav plugin's code for its simpler keyboard shortcut dialog.
As per the comment above, it would all be much nicer if Blockly only bound shortcuts relevant to the current platform or at least tagged them with a platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended as a follow-up PR to #10512 and #10551, and we are opening in draft for visibility.
The diff in this PR is not representative of the changes proposed.
See microsoft/pxt-microbit#6152. There is an alternative suggestion on the linked issue that these docs could opened in a separate sidebar tab. The work we have done here does not include that suggestion as we're hoping for more feedback on the style, position and discoverability of the help documentation before implementing further changes.
Link to demo. Please note that 'accessible blocks' needs to be set to 'on' in the settings menu.
@microbit-matt-hillsdon