Better compile error when missing call to init
#2735
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a nice error for this case, but refactoring lost it. This makes sure the interpreter is initialized before we try to read the global config so the variable isn't empty.
minestarks
reviewed
Oct 8, 2025
| ipython_helper() | ||
| start = monotonic() | ||
| global _config | ||
| interpreter = get_interpreter() |
There was a problem hiding this comment.
I think this is the online line (besides init and get_interpreter() itself) that tries to access this global directy like this... which feels like a risky pattern I'd rather not perpetuate. I wonder if instead get_interpreter() should return the config, and we always access it through that call to ensure it's initialized?
minestarks
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a nice error for this case, but refactoring lost it. This makes sure the interpreter is initialized before we try to read the global config so the variable isn't empty.