This repository was archived by the owner on Mar 29, 2021. It is now read-only.
Updated Url.js to support local images #12
Open
mainak30121994 wants to merge 1 commit intomicrosoft:masterfrom
Open
Updated Url.js to support local images #12mainak30121994 wants to merge 1 commit intomicrosoft:masterfrom
mainak30121994 wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Added support for local image files
Contributor
|
DongyuZhao
suggested changes
Jan 30, 2019
Contributor
DongyuZhao
left a comment
DongyuZhao
left a comment
There was a problem hiding this comment.
Do not modify the file in dist directly. Dist folder is the output folder of the compilation from src and any direct modification will lost once we run build. Please modify files in src and run gulp to make this change.
DongyuZhao
suggested changes
Jan 30, 2019
Contributor
DongyuZhao
left a comment
DongyuZhao
left a comment
There was a problem hiding this comment.
Please move the new test rule into a separate function for semantic comprehension.
DongyuZhao
suggested changes
Jan 30, 2019
Contributor
DongyuZhao
left a comment
DongyuZhao
left a comment
There was a problem hiding this comment.
Please do the modification based on release_1.x branch and merge it back to release_1.x since it is currently the production branch. Master branch is a working branch and wont go alive in product in a certain period of time.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for local image files