Skip to content

Accessibility and UIA Support for XAML Fabric implementation #15466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
protikbiswas100 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Accessibility and UIA Support for XAML Fabric implementation #15466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9a3dd3d
accessibility and UIA support
Dec 9, 2025
0b9a7f2
adding lint and formatting fix
Dec 9, 2025
d973ebb
adding accessibility and UIA support for XAML fabric
Dec 11, 2025
7275ba0
Change files
Dec 12, 2025
11cdc69
Merge branch 'main' into user/protikbiswas100/15325-accessibility
protikbiswas100 Dec 12, 2025
9623af8
Merge branch 'main' into user/protikbiswas100/15325-accessibility
protikbiswas100 Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-0b14d2b4-ff2a-4e94-95f7-bc04edf1a1e4.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "adding accessibility and UIA support for XAML fabric",
"packageName": "react-native-windows",
"email": "[email protected]",
"dependentChangeType": "patch"
}
21 changes: 21 additions & 0 deletions vnext/Microsoft.ReactNative/Fabric/Composition/ContentIslandComponentView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,27 @@ bool ContentIslandComponentView::focusable() const noexcept {
return true;
}

facebook::react::Tag ContentIslandComponentView::hitTest(
facebook::react::Point pt,
facebook::react::Point &localPt,
bool ignorePointerEvents) const noexcept {
facebook::react::Point ptLocal{pt.x - m_layoutMetrics.frame.origin.x, pt.y - m_layoutMetrics.frame.origin.y};
Copy link
Contributor

@JesseCol JesseCol Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible there's a scale or other transform that needs to be applied?

Copy link
Contributor Author

@protikbiswas100 protikbiswas100 Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a valid concern. The hitTest method should consider the scale/transform. Looking at the ViewComponentView::hitTest implementation, it correctly handles the origin offset


// Check if the point is within the bounds of this ContentIslandComponentView.
// This ensures that hit tests correctly return this view's tag for UIA purposes,
Copy link
Contributor

@JesseCol JesseCol Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this function ("hitTest") only called for UIA, or can it be called for other reasons?

Copy link
Contributor Author

@protikbiswas100 protikbiswas100 Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hitTest is called for multiple purposes, not just UIA:

  1. UIA/Accessibility via RootComponentView::UiaProviderFromPoint
  2. Pointer/Touch Events via CompositionEventHandler
  3. Focus Navigation:

// even when the actual content (XAML buttons, etc.) is hosted in the ContentIsland.
auto props = viewProps();
if ((ignorePointerEvents || props->pointerEvents == facebook::react::PointerEventsMode::Auto ||
props->pointerEvents == facebook::react::PointerEventsMode::BoxOnly) &&
ptLocal.x >= 0 && ptLocal.x <= m_layoutMetrics.frame.size.width && ptLocal.y >= 0 &&
ptLocal.y <= m_layoutMetrics.frame.size.height) {
localPt = ptLocal;
return Tag();
}

return -1;
}

// Helper to convert a FocusNavigationDirection to a FocusNavigationReason.
winrt::Microsoft::UI::Input::FocusNavigationReason GetFocusNavigationReason(
winrt::Microsoft::ReactNative::FocusNavigationDirection direction) noexcept {
Expand Down
3 changes: 3 additions & 0 deletions vnext/Microsoft.ReactNative/Fabric/Composition/ContentIslandComponentView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ struct ContentIslandComponentView : ContentIslandComponentViewT<ContentIslandCom

bool focusable() const noexcept override;

facebook::react::Tag hitTest(facebook::react::Point pt, facebook::react::Point &localPt, bool ignorePointerEvents)
const noexcept override;

winrt::Windows::Foundation::IInspectable EnsureUiaProvider() noexcept override;

void onGotFocus(const winrt::Microsoft::ReactNative::Composition::Input::RoutedEventArgs &args) noexcept override;
Expand Down
Loading