Skip to content

Fix DPI scaling for debugging overlay highlights #15479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
iamAbhi-916 wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix DPI scaling for debugging overlay highlights #15479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b3bff1
Fix DPI scaling for debugging overlay highlights
iamAbhi-916 Dec 16, 2025
22a2486
Change files
iamAbhi-916 Dec 16, 2025
225f44e
pointScaleFactor from m_layoutMetrics as its member of base class Com…
iamAbhi-916 Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-4a3033f2-c79a-4a04-859f-0c4647cf1b4d.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Fix DPI scaling for debugging overlay highlights",
"packageName": "react-native-windows",
"email": "[email protected]",
"dependentChangeType": "patch"
}
5 changes: 3 additions & 2 deletions vnext/Microsoft.ReactNative/Fabric/Composition/DebuggingOverlayComponentView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,11 @@ void DebuggingOverlayComponentView::HandleCommand(
if (auto root = rootComponentView()) {
auto rootVisual = root->OuterVisual();
auto brush = m_compContext.CreateColorBrush({204, 200, 230, 255});
float scaleFactor = m_layoutMetrics.pointScaleFactor;
for (auto &element : elements) {
auto overlayVisual = m_compContext.CreateSpriteVisual();
overlayVisual.Size({element.width, element.height});
overlayVisual.Offset({element.x, element.y, 0.0f});
overlayVisual.Size({element.width * scaleFactor, element.height * scaleFactor});
overlayVisual.Offset({element.x * scaleFactor, element.y * scaleFactor, 0.0f});
overlayVisual.Brush(brush);

rootVisual.InsertAt(overlayVisual, root->overlayIndex() + m_activeOverlays);
Expand Down
Loading