Skip to content

chore: improve devcontainer experience#2097

Merged
nddq merged 1 commit intomainfrom
chore/improve-devcontainer-experience
Mar 13, 2026
Merged

chore: improve devcontainer experience#2097
nddq merged 1 commit intomainfrom
chore/improve-devcontainer-experience

Conversation

@nddq
Copy link
Member

@nddq nddq commented Mar 5, 2026

Description

The devcontainer is missing several tools needed for development (LLVM/clang, jq), uses a shell script for setup instead of declarative devcontainer features, and has no CI validation.

This PR overhauls the devcontainer:

  • Replace installMoreTools.sh with declarative devcontainer features (LLVM 17, pinned versions)
  • Add persistent Go module/build cache volume mounts
  • Add jq, Kind cluster auto-creation on startup, and VS Code settings for golangci-lint + gofumpt
  • Add devcontainer.yaml CI workflow that builds the container and validates tooling
  • Expand development guide with devcontainer quick-start instructions
  • Fix markdownlint warnings in bpftrace troubleshooting doc

Related Issue

Partially addresses #2027 (lint alignment will be handled in a follow-up PR)

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...).
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

CI will validate the devcontainer builds and all tools are available via the new devcontainer.yaml workflow.

@nddq nddq requested a review from a team as a code owner March 5, 2026 14:39
@nddq nddq requested review from matmerr and vipul-21 March 5, 2026 14:39
@nddq nddq force-pushed the chore/improve-devcontainer-experience branch from 104dc35 to d106017 Compare March 5, 2026 14:43
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Retina Code Coverage Report

Total coverage no change

@nddq nddq force-pushed the chore/improve-devcontainer-experience branch 9 times, most recently from 00e6787 to 065bf0f Compare March 5, 2026 17:07
- Pin devcontainer feature versions for reproducibility
- Replace installMoreTools.sh with declarative onCreateCommand
- Add LLVM 17 feature for eBPF compilation
- Add Go module/build cache volume mounts
- Add Kind cluster auto-creation on startup
- Configure VS Code settings for golangci-lint and gofumpt
- Add port forwarding for Hubble and Retina metrics
- Add CI workflow to validate devcontainer builds
- Update contributing docs with devcontainer instructions
- Fix markdownlint warnings in bpftrace troubleshooting doc

Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>
@nddq nddq force-pushed the chore/improve-devcontainer-experience branch from 065bf0f to a8dbd3d Compare March 13, 2026 13:05
@nddq nddq changed the title chore: improve devcontainer and align golangci-lint versions chore: improve devcontainer experience Mar 13, 2026
@nddq nddq added this pull request to the merge queue Mar 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 13, 2026
@nddq nddq added this pull request to the merge queue Mar 13, 2026
Merged via the queue into main with commit 13ca780 Mar 13, 2026
34 checks passed
@nddq nddq deleted the chore/improve-devcontainer-experience branch March 13, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants