fix(ci): ensure Docker daemon is ready on Windows 2022 runners#2124
Open
fix(ci): ensure Docker daemon is ready on Windows 2022 runners#2124
Conversation
The "Build Agent Image - Windows 2022" job occasionally fails because the Docker daemon is not ready when the job starts on GitHub-hosted windows-2022 runners. Unlike Linux runners where Docker is managed by systemd and reliably available, Windows runners start Docker Engine as a Windows Service that can be slow to initialize. Add a Docker daemon readiness step that polls for Docker availability (with a 2-minute timeout) before any Docker commands run. The step attempts to start the Docker service if it is not running, then polls docker info until it succeeds. Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>
nddq
force-pushed
the
fix/windows-docker-ci-flake
branch
from
7da0b2b to
781e288
Compare
nddq
changed the title
Retina Code Coverage ReportTotal coverage decreased from
|
| Impacted Files | Coverage | |
|---|---|---|
| pkg/controllers/daemon/namespace/namespace_controller.go | 76.24% ... 78.46% (2.22%) |
⬆️ |
Decreased diff
| Impacted Files | Coverage | |
|---|---|---|
| pkg/controllers/operator/retinaendpoint/retinaendpoint_controller.go | 83.28% ... 82.25% (-1.03%) |
⬇️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "Build Agent Image - Windows 2022" job intermittently fails with:
Unlike Linux runners where Docker is managed by systemd and always available, Windows runners start Docker Engine as a Windows Service that can be slow to initialize or sometimes not running at job start.
Add a Docker daemon readiness step that polls
docker infowith a 2-minute timeout, attempting to start the service if it's not running.Related Issue
N/A — fixing flaky CI observed across multiple recent runs.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
CI will validate — the Docker readiness step itself will be exercised on the next
windows-2022run.Recent failures with the same root cause:
az acr login)az acr login)docker build)docker build)Additional Notes
N/A