-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Retina e2e scale test #720
base: main
Are you sure you want to change the base?
test: Retina e2e scale test #720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize that this is a draft, and I ordinarily don't review drafts since things are subject to change... but I figured these would be good suggestions early-on if you're planning to write some more here.
@@ -62,6 +62,20 @@ func DeleteTestInfra(subID, clusterName, location string) *types.Job { | |||
return job | |||
} | |||
|
|||
func InstallRetina(kubeConfigFilePath, chartPath string) *types.Job { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need this? Can you refactor InstallAndTestRetinaBasicMetrics
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I preferred not to change InstallAndTestRetinaBasicMetrics
since this might be in use by someone else and the scope seems to be different.
The plan for the new pipeline is to Create Infra, Install Retina, Scale Up and Run Tests, so my thinking is to create different jobs for each stage so each job could be reused somewhere else. So in the future instead of using InstallAndTestRetinaBasicMetrics
, one could [re-]use InstallRetina
, Test Basic Metrics
, and perhaps add some other set of tests. Does that make sense?
7b88495
to
a853797
Compare
04458ba
to
6662faf
Compare
Signed-off-by: Alex Castilio dos Santos <[email protected]>
6662faf
to
69189ce
Compare
Description
Create Retina E2E Scale tests using test/e2e framework.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...
). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.