Skip to content

chore: prevent accidental npm install in test fixtures#3761

Merged
tido64 merged 1 commit intomainfrom
tido/prevent-accidental-install
Sep 8, 2025
Merged

chore: prevent accidental npm install in test fixtures#3761
tido64 merged 1 commit intomainfrom
tido/prevent-accidental-install

Conversation

@tido64
Copy link
Copy Markdown
Member

@tido64 tido64 commented Sep 8, 2025

Description

Prevent accidental npm install in test fixtures

Test plan

% npm i
npm error code EBADENGINE
npm error engine Unsupported engine
npm error engine Not compatible with your version of node/npm: AwesomeGame@1.0.0
npm error notsup Not compatible with your version of node/npm: AwesomeGame@1.0.0
npm error notsup Required: {"node":"Do not install; for testing purposes only"}
npm error notsup Actual:   {"npm":"10.9.3","node":"v22.19.0"}

% pnpm i
 ERR_PNPM_UNSUPPORTED_ENGINE  Unsupported environment (bad pnpm and/or Node.js version)

Your Node version is incompatible with "/~/incubator/polyfills/test/__fixtures__".

Expected version: Do not install; for testing purposes only
Got: v22.19.0

This is happening because the package's manifest has an engines.node field specified.
To fix this issue, install the required Node version.

% yarn
Usage Error: The project in /~/package.json doesn't seem to have been installed - running an install there might help

Yarn configs are inherited and will always fail because test fixtures are not part of workspaces.

@github-actions github-actions bot added feature: metro This is related to Metro feature: align-deps This is related to align-deps chore Improvements that don't directly affect features labels Sep 8, 2025
@tido64 tido64 force-pushed the tido/prevent-accidental-install branch from c231e17 to 9589a7b Compare September 8, 2025 09:09
@tido64 tido64 force-pushed the tido/prevent-accidental-install branch from 9589a7b to 35eb443 Compare September 8, 2025 09:18
@tido64 tido64 merged commit 4167585 into main Sep 8, 2025
13 checks passed
@tido64 tido64 deleted the tido/prevent-accidental-install branch September 8, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Improvements that don't directly affect features feature: align-deps This is related to align-deps feature: metro This is related to Metro

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants