Deduplicate quiet mode handling in install-run-rush#5700
Draft
Deduplicate quiet mode handling in install-run-rush#5700
Conversation
Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
dmichon-msft
March 12, 2026 21:43
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install-run-rushhad two separate code paths that assigned an identical no-oplogger— one forRUSH_QUIET_MODEenv var and one for-q/--quietCLI arg — with duplicated object literals.Changes
install-run-rush.ts: Replace the two separateloggerassignments with a singlelet quiet: booleanflag set by either source; constructloggeronce after the arg loop.EnvironmentConfiguration.ts: Fixreset()to also reset_gitBinaryPathand_tarBinaryPath(added in the prior commit but omitted from reset); remove stray blank lines for consistency.