Skip to content

Modernize the code base #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Modernize the code base #6

wants to merge 4 commits into from

Conversation

multani
Copy link

@multani multani commented Nov 12, 2023

  • Use attrs instead of attr
  • Fully type the code base: mypy and autocompletion tool should work correctly on all the objects and types. Also, deserializing a JSON SARIF file should populate the whole datastructure correctly using cattrs.

* Use attrs instead of attr
* Fully type the code base: mypy and autocompletion tool should work
  correctly on all the objects and types.
  Also, deserializing a JSON SARIF file should populate the whole
  datastructure correctly using `cattrs`.
@multani
Copy link
Author

multani commented Nov 12, 2023

@microsoft-github-policy-service agree

@multani multani marked this pull request as ready for review November 12, 2023 17:17
Merge pull request #1 from FunJim/serialize-support
@malexmave
Copy link

Thank you for your work on this. I'm not a maintainer or affiliated with this project, but I'd love to see this merged.

One thing I noticed when looking at your repo: The code blocks in the README.md seem to be badly formatted, as there is no Python syntax highlighting and instead it simply underlines the whole code:
image

While waiting for a review from the maintainers, you may want to take another look at that :).

@multani
Copy link
Author

multani commented Apr 8, 2024

One thing I noticed when looking at your repo: The code blocks in the README.md seem to be badly formatted, as there is no Python syntax highlighting and instead it simply underlines the whole code.

This is an issue with GitHub itself, sadly :/ github/markup#1796

The README could be turned into a Markdown document instead, perhaps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants