Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: intro allowed content types in chat history channel receive. Add mixed chat image sample. #10347

Merged
merged 6 commits into from
Jan 30, 2025

Conversation

moonbox3
Copy link
Contributor

Motivation and Context

During a group chat, any file reference content created by an assistant agent, doesn't need to be communicated to a chat completion agent. Filter these types out and only include other types, like text, if available.

Description

This PR:

Contribution Checklist

@moonbox3 moonbox3 self-assigned this Jan 30, 2025
@moonbox3 moonbox3 requested a review from a team as a code owner January 30, 2025 07:51
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel documentation labels Jan 30, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Jan 30, 2025

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/agents/channels
   chat_history_channel.py79297%167, 170
TOTAL17094186189% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3048 4 💤 0 ❌ 0 🔥 1m 21s ⏱️

@moonbox3 moonbox3 changed the title Python: Don't include file ref content in chat history channel receive. Add mixed chat image sample. Python: intro allowed content types in chat history channel receive. Add mixed chat image sample. Jan 30, 2025
@moonbox3 moonbox3 enabled auto-merge January 30, 2025 22:58
@moonbox3 moonbox3 added this pull request to the merge queue Jan 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2025
@moonbox3 moonbox3 added this pull request to the merge queue Jan 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2025
@moonbox3 moonbox3 added this pull request to the merge queue Jan 30, 2025
Merged via the queue into microsoft:main with commit 605db09 Jan 30, 2025
25 checks passed
@moonbox3 moonbox3 deleted the py-assistant-file-ref-content-fix branch January 30, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents documentation python Pull requests for the Python Semantic Kernel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Python: AzureChatCompletion service fails with "Missing required parameter" error
4 participants