-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net Agents: Update experimental meta-data for graduation #10600
base: main
Are you sure you want to change the base?
Conversation
@@ -5,9 +5,8 @@ | |||
<AssemblyName>Microsoft.SemanticKernel.Agents.OpenAI</AssemblyName> | |||
<RootNamespace>Microsoft.SemanticKernel.Agents.OpenAI</RootNamespace> | |||
<TargetFrameworks>net8.0;netstandard2.0</TargetFrameworks> | |||
<NoWarn>$(NoWarn);SKEXP0110</NoWarn> | |||
<NoWarn>$(NoWarn);OPENAI001;NU5104</NoWarn> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is OPENAI001?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Underlying SDK is still beta: https://www.nuget.org/packages/OpenAI/2.2.0-beta.2
We've got the same supression in the AI connectors.
It wasn't an issue when the package identified as -beta
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Need to get feedback from @RogerBarreto regarding the content graduation changes.
I changed the abstractions and core to have an rc
suffix as agreed with LT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are planning in deprecating our KernelContens
in favor or MEAI.AIContent
s in the mid/long term.
For graduation purposes suggest moving all agent specific Content
s to Agent.Abstractions
project graduating them there instead.
@@ -9,7 +8,6 @@ namespace Microsoft.SemanticKernel; | |||
/// <summary> | |||
/// Content type to support file references. | |||
/// </summary> | |||
[Experimental("SKEXP0110")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep these experimental per Rogers comments
Motivation and Context
As part of Agent Graduation, the
Experimental
attributes must be more precisely defined.beta
prior to graduation #10303Description
Apply
Experimental
attributes for non-graduating artifacts for:Microsoft.SementicKernel.Agents.Abstractions
Microsoft.SementicKernel.Agents.Core
Microsoft.SementicKernel.Agents.OpenAI
Contribution Checklist