.Net: IVectorStore implementation for Azure SQL #10623
Open
+3,320
−719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 186fda2.
…o sqlServerTests # Conflicts: # dotnet/SK-dotnet.sln
…t throws NotImplementedException
…ngs that need to be addressed
The ToListAsync change is just a wokaround dotnet/runtime#79782 (comment)
adamsitnik
had a problem deploying
to
integration
GitHub Actions
Failure
westey-m
reviewed
Feb 21, 2025
westey-m
reviewed
Feb 21, 2025
dotnet/src/InternalUtilities/src/Data/VectorStoreRecordPropertyReader.cs
Show resolved
Hide resolved
westey-m
reviewed
Feb 21, 2025
dotnet/src/Connectors/Connectors.Memory.SqlServer/SqlServerCommandBuilder.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Feb 21, 2025
dotnet/src/Connectors/Connectors.Memory.SqlServer/SqlServerCommandBuilder.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Feb 21, 2025
dotnet/src/Connectors/Connectors.Memory.SqlServer/SqlServerCommandBuilder.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Feb 21, 2025
dotnet/src/Connectors/Connectors.Memory.SqlServer/SqlServerVectorStore.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Feb 21, 2025
dotnet/src/Connectors/Connectors.Memory.SqlServer/SqlServerVectorStore.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Feb 21, 2025
dotnet/src/Connectors/Connectors.Memory.SqlServer/SqlServerVectorStore.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Feb 21, 2025
dotnet/src/Connectors/Connectors.Memory.SqlServer/SqlServerVectorStoreRecordCollection.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Feb 21, 2025
dotnet/src/Connectors/Connectors.Memory.SqlServer/SqlServerVectorStoreRecordCollection.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Feb 21, 2025
dotnet/src/Connectors/Connectors.Memory.SqlServer/SqlServerVectorStoreRecordCollection.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Feb 21, 2025
dotnet/src/Connectors/Connectors.Memory.SqlServer/SqlServerVectorStoreRecordCollection.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Feb 21, 2025
dotnet/src/Connectors/Connectors.Memory.SqlServer/SqlServerVectorStoreRecordCollection.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Feb 21, 2025
dotnet/src/Connectors/VectorData.Abstractions/RecordAttributes/VectorStoreRecordKeyAttribute.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Feb 21, 2025
dotnet/src/Connectors/VectorData.Abstractions/RecordDefinition/VectorStoreRecordKeyProperty.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Feb 21, 2025
...et/src/VectorDataIntegrationTests/SqlServerIntegrationTests/SqlServerIntegrationTests.csproj
Show resolved
Hide resolved
westey-m
reviewed
Feb 21, 2025
dotnet/src/VectorDataIntegrationTests/SqlServerIntegrationTests/SqlServerVectorStoreTests.cs
Show resolved
Hide resolved
westey-m
reviewed
Feb 21, 2025
dotnet/src/VectorDataIntegrationTests/SqlServerIntegrationTests/SqlServerVectorStoreTests.cs
Outdated
Show resolved
Hide resolved
…/VectorStoreRecordKeyAttribute.cs Co-authored-by: westey <[email protected]>
adamsitnik
had a problem deploying
to
integration
GitHub Actions
Failure
- use abstract instead of partial class - make Dimensions mandatory - remove support of string collections - map "dot" to Negative Dot - make SqlServerVectorStoreRecordCollection public - make AutoGenerate init rather than readonly property - add net472 target for the test project, make it compile - use unique collection names so multiple users can run the same tests against shared db instance - verify that parameterless ctor is present for TRecord - make sure that exceptions are wrapped
adamsitnik
had a problem deploying
to
integration
GitHub Actions
Failure
- add support for IVectorStoreRecordMapper - respect IncludeVectors - add VectorSearch tests (based on existing tests) - fix typos
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
adamsitnik
had a problem deploying
to
integration
GitHub Actions
Failure
- escape the index name (by quoting it) - don't create index if it already exists as part of CreateCollectionIfNotExistsAsync - don't wrap NotSupportedException with VectorStoreOperationException when the user tried to create a query that is not supported like non-supported distance function for given index)
adamsitnik
had a problem deploying
to
integration
GitHub Actions
Failure
adamsitnik
requested a deployment
to
integration
GitHub Actions
In progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is ready for review.
fixes #10416