Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Improve agent getting started samples #10667

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TaoChenOSU
Copy link
Contributor

@TaoChenOSU TaoChenOSU commented Feb 25, 2025

Motivation and Context

We are improving developer experience by updating the agent getting started samples.

Description

Simplify the agent getting started samples by removing unnecessary code and add excessive comments to make sure we are only doing what we need to get started.

Contribution Checklist

@TaoChenOSU TaoChenOSU added python Pull requests for the Python Semantic Kernel agents labels Feb 25, 2025
@TaoChenOSU TaoChenOSU self-assigned this Feb 25, 2025
@TaoChenOSU TaoChenOSU requested a review from a team as a code owner February 25, 2025 05:21
@github-actions github-actions bot changed the title Improve agent getting started samples Python: Improve agent getting started samples Feb 25, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Feb 26, 2025

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/agents/azure_ai
   agent_thread_actions.py34112962%140, 142, 177–180, 365, 367, 406–407, 433, 436–440, 443–455, 458–489, 495–502, 505–518, 534–565, 609, 612, 641–675, 738, 743–748, 768–775, 806–815, 858–868
   azure_ai_agent.py931485%95, 97, 103, 112–117, 119, 121, 143–146, 194, 254
semantic_kernel/agents/chat_completion
   chat_completion_agent.py110794%82, 85, 94–99, 124, 192
semantic_kernel/agents/group_chat
   agent_chat.py127398%80, 103, 176
TOTAL19048232888% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3214 5 💤 0 ❌ 0 🔥 1m 27s ⏱️

@@ -122,7 +124,10 @@ def __init__(

@classmethod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can actually be updated to a static method since we're not doing anything with cls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents documentation python Pull requests for the Python Semantic Kernel
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants