.Net: [.NET] Fix missing plugin name when converting function calls#13585
Open
OiPunk wants to merge 2 commits intomicrosoft:mainfrom
Open
.Net: [.NET] Fix missing plugin name when converting function calls#13585OiPunk wants to merge 2 commits intomicrosoft:mainfrom
OiPunk wants to merge 2 commits intomicrosoft:mainfrom
Conversation
moonbox3
added
.NET
github-actions
bot
changed the title
OiPunk
force-pushed
the
codex/semantic-kernel-13516-function-call-plugin-parse
branch
from
5bfb48e to
46985c3
Compare
Author
|
Gentle ping — any feedback on this fix? Let me know if there's anything I should adjust. |
|
|
||
| Microsoft.SemanticKernel.FunctionCallContent CreateFunctionCallContent(Microsoft.Extensions.AI.FunctionCallContent functionCallContent) | ||
| { | ||
| var (functionName, pluginName) = ParseFunctionName(functionCallContent.Name); |
Author
There was a problem hiding this comment.
Good call — updated to use FunctionName.Parse. Thanks for the pointer!
OiPunk
force-pushed
the
codex/semantic-kernel-13516-function-call-plugin-parse
branch
from
b047452 to
ad42e2f
Compare
Signed-off-by: OiPunk <codingpunk@gmail.com>
OiPunk
force-pushed
the
codex/semantic-kernel-13516-function-call-plugin-parse
branch
from
ad42e2f to
4309d6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes function-call conversion from
Microsoft.Extensions.AI.ChatMessageso plugin/function names are preserved instead of collapsing into a singleFunctionNamestring.Why
ChatMessageExtensions.ToChatMessageContent(...)previously mappedFunctionCallContent.Namedirectly intoFunctionCallContent.FunctionNameand always leftPluginNameempty.This breaks scenarios where providers return fully-qualified tool names (for example
time_ReadFile), producing empty plugin names in user code and making invocation/diagnostics inconsistent.Changes
(plugin, function)during conversion..-_(safe fallback only when there is a single underscore and the function segment is PascalCase).FunctionResultContentfrom the matched function call.ChatMessageExtensionsTestsfor:Verification
/Users/liweiguang/.dotnet/dotnet test dotnet/src/SemanticKernel.UnitTests/SemanticKernel.UnitTests.csproj --filter ChatMessageExtensionsTests --nologo/Users/liweiguang/.dotnet/dotnet test dotnet/src/SemanticKernel.UnitTests/SemanticKernel.UnitTests.csproj --filter ChatMessageExtensionsTests --collect:"XPlat Code Coverage" --results-directory /tmp/sk-13516-coverage --nologoCloses #13516